Skip to content

[18.0][ADD] partner_firstname_auth_signup#2118

Open
legalsylvain wants to merge 2 commits into
OCA:18.0from
grap:18.0-ADD-partner_firstname_auth_signup
Open

[18.0][ADD] partner_firstname_auth_signup#2118
legalsylvain wants to merge 2 commits into
OCA:18.0from
grap:18.0-ADD-partner_firstname_auth_signup

Conversation

@legalsylvain
Copy link
Copy Markdown
Contributor

@legalsylvain legalsylvain commented Aug 23, 2025 •
edited
Loading

This module is a glue module installed when OCA partner_firstname module and Odoo signup module are installed.

This allows the customer to enter their first and last names in the signup form.

image

depends on :

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch 4 times, most recently from edb019d to 5518f49 Compare August 23, 2025 23:10
@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch 3 times, most recently from f8c0a9f to d652ebc Compare September 1, 2025 09:31
@legalsylvain
Copy link
Copy Markdown
Contributor Author

legalsylvain commented Sep 1, 2025

@rvalyi : you could be interested by this one.

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch from d652ebc to 4f59ee4 Compare November 23, 2025 22:09
@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch from 4f59ee4 to 6b7470b Compare November 28, 2025 09:17
maisim
maisim approved these changes Nov 28, 2025
View reviewed changes
Copy link
Copy Markdown

@maisim maisim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + live tests:
http://oca-partner-contact-18-0-pr2118-4f59ee46496b.runboat.odoo-community.org/odoo/users/8

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch 2 times, most recently from c3465e1 to 4fa166a Compare March 10, 2026 22:40
@legalsylvain legalsylvain mentioned this pull request Mar 11, 2026
Merged
@NL66278
Copy link
Copy Markdown
Contributor

NL66278 commented Apr 28, 2026

@legalsylvain If you rebase the dependency problem should be gone now.

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch from 4fa166a to 8c9f827 Compare April 28, 2026 08:49
@OCA-git-bot OCA-git-bot added series:18.0 mod:partner_firstname_auth_signup Module partner_firstname_auth_signup labels Apr 28, 2026
@NL66278
Copy link
Copy Markdown
Contributor

NL66278 commented May 18, 2026

@legalsylvain I see one probably related test failure:

2026-04-28 08:54:18,466 391 INFO odoo odoo.addons.partner_is_company_auth_signup.tests.test_partner_is_company_auth_signup: ====================================================================== 
2026-04-28 08:54:18,466 391 ERROR odoo odoo.addons.partner_is_company_auth_signup.tests.test_partner_is_company_auth_signup: FAIL: TestPartnerIscompanyAuthSignup.test_signup_workflow_person
Traceback (most recent call last):
  File "/__w/partner-contact/partner-contact/partner_is_company_auth_signup/tests/test_partner_is_company_auth_signup.py", line 59, in test_signup_workflow_person
    self.assertTrue(new_user)
AssertionError: res.users() is not true

Would be nice to solve this, then I can approve and merge.

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch from 8c9f827 to a2db97c Compare May 23, 2026 21:15
@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch from a2db97c to e81724a Compare June 1, 2026 21:36
BhaveshHeliconia
BhaveshHeliconia reviewed Jun 4, 2026
View reviewed changes
Comment thread partner_firstname_auth_signup/views/auth_signup_login_templates.xml Outdated
Comment thread partner_firstname_auth_signup/static/src/js/signup.esm.js
@@ -0,0 +1,40 @@
import publicWidget from "@web/legacy/js/public/public_widget";
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be scoped to src folder only

Copy link
Copy Markdown
Contributor Author

@legalsylvain legalsylvain Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the correct syntax for you ? I'm not a JS expert.

I took exemple on current OCA modules (at least in 7 modules in V18) :

./partner-contact/partner_firstname_auth_signup/static/src/js/signup.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";
./website/website_select2/static/src/js/website_select2.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";
./website/website_form_require_legal/static/src/js/terms_and_conditions.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";
./website/website_form_require_legal/static/src/js/submit_button.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";
./website/website_altcha/static/src/signup/signup.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";
./website/website_cf_turnstile_login/static/src/js/turnstileCaptchaSignIn.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";
./timesheet/hr_timesheet_portal/static/src/js/hr_timesheet_portal.esm.js:import publicWidget from "@web/legacy/js/public/public_widget";

Comment thread partner_firstname_auth_signup/views/auth_signup_login_templates.xml Outdated
type="checkbox"
id="checkbox_config_lastname_required"
t-att-checked="lastname_required"
style="display: none;"
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use d-none class instead.

Copy link
Copy Markdown
Contributor Author

@legalsylvain legalsylvain Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Naive question: why it is best to use "d-none" class instead of "display:none" ?

d-none looks an alias...
https://github.com/odoo/odoo/blob/18.0/addons/web/static/lib/bootstrap/dist/css/bootstrap.css#L7372


.d-none {
  display: none !important;
}

Comment thread partner_firstname_auth_signup/controllers/main.py
def get_auth_signup_qcontext(self):
qcontext = super().get_auth_signup_qcontext()
config_required = (
request.env["ir.config_parameter"]
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer variable usage here

Copy link
Copy Markdown
Contributor Author

@legalsylvain legalsylvain Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer variable usage here

sorry I don't get this one. Could you elaborate ?

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

BhaveshHeliconia commented Jun 4, 2026

We'll need other modules(partner_middlename_auth_signup and partner_second_lastname_auth_signup) as well in future

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_firstname_auth_signup branch from e81724a to efdb411 Compare June 4, 2026 20:01
@OCA-git-bot OCA-git-bot added the mod:partner_is_company_auth_signup Module partner_is_company_auth_signup label Jun 4, 2026
@legalsylvain
Copy link
Copy Markdown
Contributor Author

legalsylvain commented Jun 4, 2026

We'll need other modules(partner_middlename_auth_signup and partner_second_lastname_auth_signup) as well in future

I don't use middlename and second_lastname, but indeed, it will be required.

@NL66278 : fixed ! CI is green.

@NL66278
Copy link
Copy Markdown
Contributor

NL66278 commented Jun 4, 2026

@legalsylvain I tend to think it is good enough, but you could solve the coverage problem by adding a unit test for _signup_retrieve_info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia left review comments

@maisim maisim maisim approved these changes

@hparfr hparfr hparfr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:partner_firstname_auth_signup Module partner_firstname_auth_signup mod:partner_is_company_auth_signup Module partner_is_company_auth_signup needs fixing series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@legalsylvain @NL66278 @BhaveshHeliconia @maisim @hparfr @dreispt @OCA-git-bot