Skip to content

[ADD] New module: partner_is_company_auth_signup#2123

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
grap:18.0-ADD-partner_is_company_auth_signup
Apr 28, 2026
Merged

[ADD] New module: partner_is_company_auth_signup#2123
OCA-git-bot merged 1 commit into
OCA:18.0from
grap:18.0-ADD-partner_is_company_auth_signup

Conversation

@legalsylvain
Copy link
Copy Markdown
Contributor

Add a new radiobox input in signup page, to know if the user is a company, or an individual. The feature is similar to the back-office main partner page.

It avoids to have bad information, when companies are creating accounts. (is_company is unchecked by default in Odoo Core)

image

@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Aug 31, 2025

interesting feature. Sure you prefer to propose it as AGPL rather than LGPL? AGPL is often a bit of a stretch for portal modules...

@legalsylvain
Copy link
Copy Markdown
Contributor Author

interesting feature. Sure you prefer to propose it as AGPL rather than LGPL? AGPL is often a bit of a stretch for portal modules...

I don't think that a lot of modules will depends on this one. It is a quite trivial one.
And to a certain extent, I like the contamination of the AGPL. ;-)

@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Aug 31, 2025

interesting feature. Sure you prefer to propose it as AGPL rather than LGPL? AGPL is often a bit of a stretch for portal modules...

I don't think that a lot of modules will depends on this one. It is a quite trivial one.
And to a certain extent, I like the contamination of the AGPL. ;-)

well eventually l10n_br_portal may depend on it as this is company thing is something that used to cause troubles. But after we change l10n_br_base to LGPL we would like to keep l10n_br_portal as LGPL as well. So this could be a use case. But not a big deal either.

cc @marcelsavegnago

@legalsylvain
Copy link
Copy Markdown
Contributor Author

legalsylvain commented Aug 31, 2025

well eventually l10n_br_portal may depend on it as this is company thing is something that used to cause troubles

Hi. I understand That is used to cause troubles. But I don't understand why you could add a dependency to that module.

This module just add a radio input on a form. no need to depend on it, just install it, IMO. Please, elaborate if you can.

thanks !

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_is_company_auth_signup branch from cda667c to 3116bc6 Compare August 31, 2025 22:11
@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Aug 31, 2025

well eventually you licensed it as AGPL without thinking too much about it and was ready to change. That's why I asked. But sure enough if it stays AGPL and we aim to put l10n_br_portal as LGPL, then we wouldn't depend on it, no big deal as I said.

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_is_company_auth_signup branch from 3116bc6 to e84747e Compare September 1, 2025 08:56
@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_is_company_auth_signup branch from e84747e to 57f6a20 Compare September 1, 2025 12:45
@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_is_company_auth_signup branch 2 times, most recently from fc2094c to 7c268fa Compare November 28, 2025 09:18
Copy link
Copy Markdown

@maisim maisim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_is_company_auth_signup branch from 7c268fa to 35cd50d Compare March 10, 2026 21:37
Add a new radiobox input in signup page, to know if the user is a company, or an individual.
The feature is similar to the back-office main partner page.

It avoids to have bad information, when companies are creating accounts.
(is_company is unchecked by default in Odoo Core)
@legalsylvain legalsylvain force-pushed the 18.0-ADD-partner_is_company_auth_signup branch from 35cd50d to abd9506 Compare March 10, 2026 22:39
@legalsylvain
Copy link
Copy Markdown
Contributor Author

@hparfr, could you make a review and put a little 👍 on this one ? it is preventing the merge of #2118 that you reviewed.

thanks !

@legalsylvain
Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Copy Markdown
Contributor Author

Hi some @OCA maintainers could merge this one ?
thanks !

Copy link
Copy Markdown
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278
Copy link
Copy Markdown
Contributor

NL66278 commented Apr 28, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-2123-by-NL66278-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 71181f2 into OCA:18.0 Apr 28, 2026
9 of 13 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at dd843c8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants