[ADD] New module: partner_is_company_auth_signup#2123
Conversation
|
interesting feature. Sure you prefer to propose it as AGPL rather than LGPL? AGPL is often a bit of a stretch for portal modules... |
I don't think that a lot of modules will depends on this one. It is a quite trivial one. |
well eventually l10n_br_portal may depend on it as this is company thing is something that used to cause troubles. But after we change l10n_br_base to LGPL we would like to keep l10n_br_portal as LGPL as well. So this could be a use case. But not a big deal either. |
Hi. I understand That is used to cause troubles. But I don't understand why you could add a dependency to that module. This module just add a radio input on a form. no need to depend on it, just install it, IMO. Please, elaborate if you can. thanks ! |
cda667c to
3116bc6
Compare
|
well eventually you licensed it as AGPL without thinking too much about it and was ready to change. That's why I asked. But sure enough if it stays AGPL and we aim to put l10n_br_portal as LGPL, then we wouldn't depend on it, no big deal as I said. |
3116bc6 to
e84747e
Compare
e84747e to
57f6a20
Compare
fc2094c to
7c268fa
Compare
maisim
left a comment
There was a problem hiding this comment.
code review + live test from http://oca-partner-contact-18-0-pr2123-7c268faf2446.runboat.odoo-community.org
👏
7c268fa to
35cd50d
Compare
Add a new radiobox input in signup page, to know if the user is a company, or an individual. The feature is similar to the back-office main partner page. It avoids to have bad information, when companies are creating accounts. (is_company is unchecked by default in Odoo Core)
35cd50d to
abd9506
Compare
|
/ocabot merge patch |
|
Sorry @legalsylvain you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
Hi some @OCA maintainers could merge this one ? |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at dd843c8. Thanks a lot for contributing to OCA. ❤️ |
Add a new radiobox input in signup page, to know if the user is a company, or an individual. The feature is similar to the back-office main partner page.
It avoids to have bad information, when companies are creating accounts. (is_company is unchecked by default in Odoo Core)