[18.0][ADD] sale_multi_discount#4364
Draft
LorenzoC0 wants to merge 1 commit into
Draft
Conversation
Adds a distribution-like field in the sale order line discount column.
OCA-git-bot
added
series:18.0
mod:sale_multi_discount
eLBati
suggested changes
May 27, 2026
| back through our ``write`` override and squash a freshly-edited | ||
| multi-discount rule into a single flattened value. | ||
| """ | ||
| self._compute_discount_distribution() |
Member
There was a problem hiding this comment.
if product_id or product_uom or product_uom_qty change, the distribution should be emptied
| for vals in vals_list: | ||
| if "discount" in vals and "discount_distribution" not in vals: | ||
| discount_val = vals.pop("discount") | ||
| if discount_val: |
Member
There was a problem hiding this comment.
if discount_val is 0, shouldn't we still empty discount_distribution?
| ], | ||
| "data": [ | ||
| "views/sale_order_views.xml", | ||
| "report/sale_order_report.xml", |
Member
There was a problem hiding this comment.
We should probably extend sale.sale_portal_templates as well
| <td t-if="display_discount" class="text-end text-nowrap"> | ||
| <t t-if="line.discount_distribution and len(line.discount_distribution) > 1"> | ||
| <t t-foreach="line.discount_distribution" t-as="d" t-key="d_index"> | ||
| <span t-out="'%.2f' % d"/>%<t t-if="not d_last"> + </t> |
Member
There was a problem hiding this comment.
is it possible to use formatLang?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OCA/account-invoicing#2364
This module adds a distribution-like field in the sale order line discount column, enabling infinite multiplicative discounts.
This module likely conflicts with some other modules that modify the behavior of the discount field, such as
sale_global_discount. I could use some help figuring out which of these modules are incompatible, so I can add them as exclusions in the manifest. Thanks!