feat(meta): vendor OO-LD 1.0.0-rc.4 and rc.5 - #169
Merged
Merged
Conversation
The newest tracked meta-schema was rc.3, so a validator run resolved to 73 rules and could not see the 19 added since, including the root @context requirement. - VOCAB_WITHDRAWN excludes a keyword the vocabulary removed: the fixture corpus tracks the newest release, so nothing it contains can cover x-oold-reverse-default-properties while rc.1 still declares it - probe schemas in the test suite carry @context, required of a document from rc.4 - a schema without a root @context is now refused by the meta-schema, so the round-trip test asserts that this is the only finding
Contributor
Release previewMerging this PR would release v1.1.0 (current: Changelog preview (truncated)## v1.1.0 (2026-09-27)
### Features
- **meta**: Vendor OO-LD 1.0.0-rc.4 and rc.5
([`fae8ed0`](https://github.com/OO-LD/oold-python/commit/fae8ed07142e4af41215a77792ee40aa10e34661))
Preview via python-semantic-release and conventional commits. |
Contributor
📊 Benchmark ResultsClick to see benchmark comparisonThreshold: 1.3x (30% slower triggers a regression warning) Note: Benchmarks are informational only and won't fail the build. 💡 Tip: Download the |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newest tracked meta-schema was
1.0.0-rc.3.meta_storeresolves the default to the highest tracked version, sopip install oold[validation] && oold validateran against rc.3's 73 rules and could not see the 19 added since, includingOOLD-SCH-96a3, the root@contextrequirement that rc.4 led with.After: the default resolves to
1.0.0-rc.5, 92 rules, 47 machine-checkable.Three consequences, each handled
A withdrawn keyword breaks coverage for older versions. The fixture corpus is refreshed from the newest tag, so it cannot exercise
x-oold-reverse-default-properties, which the vocabulary removed, while1.0.0-rc.1still declares it.VOCAB_EXEMPTdoes not apply: that covers keywords outside thex-oold-prefix, and this one has it. AddedVOCAB_WITHDRAWNas the separate concept and excluded it fromvocabulary_coverage.Probe schemas needed
@context. Three tests build a minimal document to check the dialect resolves; from rc.4 a document requires@contextas well as$id. The comment already noted the$idcase for the same reason.no_context.schema.jsonis now refused outright. It is a deliberately broken fixture and the meta-schema rejects it, which is correct. The test's subject is the round trip, so it still assertsroundtrip.generatedis OK and coverage WARNs, and now assertsschema.metais the only failure rather than that there are none.Fixture refresh also picked up the
http://schema.orgcorrection intests/data/oold/UiAnnotations.schema.json(OO-LD/oold-schema#179).Verified:
504 passed, 7 skipped;oold validateover the specification'sexamples/reports 380 passing checks against1.0.0-rc.5.