Closed Forest Fix on Advanced Logic

[shirosoluna]

downgrade Closed_Forest to closed_deku with misc tricks on and ER

[r0bd0g]

I think it says overworld spawns in the tooltip twice.
Yeah the tooltip is wrong still.

[shirosoluna]

I think it says overworld spawns in the tooltip twice. Yeah the tooltip is wrong still.

It had "Shuffle Overworld Spawns" in advanced. So wasnt necessarily repeated twice but probably looked weird with line breaks. But I updated it to be cleaner. It should behave the same as glitchless, however added shuffle grottos in advanced logic bc of dampe grave thing that Maple found.

[r0bd0g]

I had figured the duplicated ow spawns text was supposed to have been grottos.

[fenhl]

Quick note that this will have to be adjusted for #1531 if that gets merged before this.

[shirosoluna]

I accidentally put the new heart texture to this version not realizing that this was still open, and force pushed it back to where it was sorry. It should be ok now but if you see anything amiss let me know

[fenhl]

Seems to be okay yes. By the way, has this PR been tested?

[shirosoluna]

Seems to be okay yes. By the way, has this PR been tested?

it generates seeds, but I'd have to read the spoiler logs to ensure that it works as intended. Is there something the OoTstats could do for this?
It's basically is what r0bdog said to do with how closed forest reverts to closed deku and adding the can_leave_forest. It will not be apparent to the user and the spoiler log will still show closed forest as this only affects item placements and logic. Maybe the playthrough would be different?? So I am unsure how to verify it except manual review of some kind...

[fenhl]

Yeah I think the tester would have to manually look for a spoiler log where they can tell that it's using the Open Forest logic. Maybe a plando could be constructed in a way to force that?

[fenhl]

Tested by confirming that this plando generates successfully:

{
    "settings": {
        "logic_rules": "advanced",
        "shuffle_grotto_entrances": true,
        "item_pool_value": "minimal"
    },
    "locations": {
        "Market 10 Big Poes": "Slingshot"
    }
}

But not when disabling shuffle_grotto_entrances.