Skip to content

Closed Forest Fix on Advanced Logic #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fenhl merged 4 commits into from
Oct 4, 2025
Merged

Closed Forest Fix on Advanced Logic #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec4ad14
Downgrades Closed Forest to Open Deku with Grotto ER on Advanced logic
dotzo Aug 31, 2025
2a13196
Merge pull request #4 from dotzo/advanced-glitchlogic-release
shirosoluna Sep 5, 2025
e2095d3
trailing whitespace
shirosoluna Sep 5, 2025
5f8866c
update tooltip
shirosoluna Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions SettingsList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,11 +1231,12 @@ class SettingInfos:
required to access the Deku Tree. Items needed for this will be
guaranteed inside the forest area. This setting is incompatible
with starting as adult, and so Starting Age will be locked to Child.
With either "Shuffle Interior Entrances" set to "All", "Shuffle
Overworld Entrances" on, "Randomize Warp Song Destinations" on
or "Randomize Overworld Spawns" on, Closed Forest will instead
be treated as Closed Deku with starting age Child and WILL NOT
guarantee that these items are available in the forest area.
With any of "Shuffle Interior Entrances" set to "All", "Shuffle
Overworld Entrances" on, "Randomize Warp Song Destinations" on,
"Randomize Overworld Spawns" on, or "Shuffle Grottos" in Advanced
Logic, Closed Forest will instead be treated as Closed Deku with
starting age Child and WILL NOT guarantee that these items are
available in the forest area.
''',
shared = True,
disable = {
Expand Down
4 changes: 3 additions & 1 deletion World.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ def __init__(self, world_id: int, settings: Settings, resolve_randomized_setting

if (settings.open_forest == 'closed'
and (self.shuffle_special_interior_entrances or settings.shuffle_hideout_entrances or settings.shuffle_overworld_entrances
or settings.warp_songs or settings.spawn_positions)):
or settings.warp_songs or settings.spawn_positions
or (settings.logic_rules == 'advanced' and settings.shuffle_grotto_entrances)
)):
self.settings.open_forest = 'closed_deku'

if settings.triforce_goal_per_world > settings.triforce_count_per_world:
Expand Down