Skip to content

fix HitMultiCardApi getting error 400 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arielvicente wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix HitMultiCardApi getting error 400 #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e495f
add missing header to prevent error 400
arielvicente Feb 25, 2026
8c20e49
use EscapeDataString to remove spaces from query
arielvicente Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions PDBot.Core/API/Scryfall.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Linq;
using System.Net;
using System.Text;
using System.Threading.Tasks;

namespace PDBot.Core.API
{
Expand Down Expand Up @@ -49,7 +48,9 @@ public static Card GetCardFromSearch(string name)
return Cache[name];
}

var address = $"/cards/search?q={name}+lang:en&include_multilingual=true";
var query = $"{name} lang:en";
var encodedQuery = Uri.EscapeDataString(query);
var address = $"/cards/search?q={encodedQuery}&include_multilingual=true";
var cards = HitMultiCardAPI(address).ToArray();
var card = cards.FirstOrDefault(c => c.Names.Contains(name));
return card;
Expand Down Expand Up @@ -80,7 +81,7 @@ public static string[] CardCatalog()
BaseAddress = "https://api.scryfall.com/",
Encoding = Encoding.UTF8,
};
wc.Headers[HttpRequestHeader.UserAgent] = "PDBot";
SetUpHeaders(wc);
var blob = wc.DownloadString("catalog/card-names");
var json = Newtonsoft.Json.JsonConvert.DeserializeObject(blob) as JObject;
CardNames = json["data"].Values<string>().ToArray<string>();
Expand All @@ -105,9 +106,8 @@ private static Card HitAPI(string address)
using var wc = new WebClient
{
BaseAddress = "https://api.scryfall.com/",

};
wc.Headers[HttpRequestHeader.UserAgent] = "PDBot";
SetUpHeaders(wc);
var blob = wc.DownloadString(address);
var json = Newtonsoft.Json.JsonConvert.DeserializeObject(blob) as JObject;
return ParseJson(json);
Expand Down Expand Up @@ -150,12 +150,13 @@ private static IEnumerable<Card> HitMultiCardAPI(string address)
string blob;
try
{

using var wc = new WebClient
{
BaseAddress = "https://api.scryfall.com/"
};
wc.Headers[HttpRequestHeader.UserAgent] = "PDBot";

SetUpHeaders(wc);

Console.WriteLine(address);
blob = wc.DownloadString(address);
}
Expand Down Expand Up @@ -191,5 +192,11 @@ private static IEnumerable<Card> HitMultiCardAPI(string address)
yield break;
}
}

static void SetUpHeaders(WebClient wc)
{
wc.Headers[HttpRequestHeader.UserAgent] = "PDBot";
wc.Headers[HttpRequestHeader.Accept] = "application/json";
}
}
}