HostDataSSLCert#serial type too small#3
Open
CausticKirbyZ wants to merge 2 commits into
Open
Conversation
changed HostDataSSLCert#serial type to a UInt128. This supports bigger serial numbers and fixes any parsing issues with numbers larger than an Int64 supports
changed it to a string for more support as UInt128 still wasnt big enough
husnahusain
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change HostDataSSLCert#serial type from UInt64? to UInt128?.
This supports bigger serial numbers and fixes parsing issues with numbers larger than an Int64 supports. This wont fully fix the parsing issue but will allow for more support without breaking int comparisons.
a more complete parsing fix could be implemented by converting to a string using the following: