Skip to content

HostDataSSLCert#serial type too small #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CausticKirbyZ wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HostDataSSLCert#serial type too small #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c128ac
Update ssl.cr
CausticKirbyZ Oct 7, 2024
7d02b02
Update ssl.cr
CausticKirbyZ Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/shodan/parsers/host_services/ssl.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ module Shodan
property version : Int32?
property extensions : Array(HostDataSSLExtensions)?
property fingerprint : Hash(String, String)?
property serial : Int64?

# property serial : UInt128?
# changed to the below as there are certs with larger serial numbers than an UInt128 supports
@[JSON::Field(converter: String::RawConverter)]
property serial : String?

property subject : HostDataSslSubject
property issuer : HostDataSslIssuer
end
Expand Down