Update CSV adapter - #748
Draft
AndrewSasmito wants to merge 10 commits into
Draft
Conversation
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com> Refactor CsvInputAdapterManager for improved clarity Add new fields and methods to CsvInputAdapterManager Fix error
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
AndrewSasmito
requested review from
AdamGlustein,
alexddobkin,
arhamchopra,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
August 13, 2026 05:10
timkpaine
requested changes
Aug 13, 2026
|
|
||
| - **line 3**: this is where the instance of an adapter *--impl--* registers itself with the `CSVReaderImpl`. | ||
| - **line 6+**: this is where we define `CSVReadAdapter`, the *--graph--* time representation of a CSV adapter, returned from `CSVReader.subscribe` | ||
| TODO |
Member
There was a problem hiding this comment.
We definitely want to keep an example of this
Author
There was a problem hiding this comment.
For sure, I will try rewriting the docs right before we merge in case changes are made during review (which might require another rewrite).
robambalu
reviewed
Aug 13, 2026
Collaborator
There was a problem hiding this comment.
I would really want to see the test file unchanged to confirm no changes, but can add new tests as needed
Author
There was a problem hiding this comment.
I had to change some parts of the test to support the new engine.
- Change the order of arguments since symbol is now optional
- I only accept strings for now for this prototype
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
Signed-off-by: Andrew Sasmito <asasmito1920@gmail.com>
robambalu
marked this pull request as draft
August 14, 2026 15:06
timkpaine
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #259
Summary
Rewrite the CSV adapter to use a C++ engine rather than pure Python.
Limitations
Initial current implementation is with basic C++, hopefully we can do the following: