-
Notifications
You must be signed in to change notification settings - Fork 87
Update CSV adapter #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AndrewSasmito
wants to merge
10
commits into
Point72:main
Choose a base branch
from
AndrewSasmito:csv-adapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update CSV adapter #748
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
45dac30
Add CsvInputAdapterManager
AndrewSasmito d448879
Create linker and update cmakes
AndrewSasmito e06bcb7
Update python side and add tests
AndrewSasmito e62190f
Fix linter issue
AndrewSasmito 909f6b6
Remove CmakeFiles
AndrewSasmito ca746a4
Remove compile_commands
AndrewSasmito f2cba83
Merge branch 'main' into csv-adapter
AndrewSasmito 02be585
Address comments
AndrewSasmito 25d0f84
Address comments + Add in field map dict
AndrewSasmito 612af35
Merge branch 'main' into csv-adapter
AndrewSasmito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # No external dependencies are needed at this time | ||
| cmake_minimum_required(VERSION 3.7.2) | ||
|
|
||
| set(DepsCsvAdapter_FOUND TRUE) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| set(CSV_HEADER_FILES | ||
| CsvInputAdapterManager.h | ||
| ) | ||
|
|
||
| set(CSV_SOURCE_FILES | ||
| CsvInputAdapterManager.cpp | ||
| ${CSV_HEADER_FILES} | ||
| ) | ||
|
|
||
| add_library(csp_csv_adapter STATIC ${CSV_SOURCE_FILES}) | ||
|
|
||
| set_target_properties(csp_csv_adapter PROPERTIES | ||
| PUBLIC_HEADER "${CSV_HEADER_FILES}" | ||
| ) | ||
|
|
||
| target_link_libraries(csp_csv_adapter | ||
| PRIVATE | ||
| csp_engine | ||
| ) | ||
|
|
||
| install(TARGETS csp_csv_adapter | ||
| PUBLIC_HEADER DESTINATION include/csp/adapters/csv | ||
| RUNTIME DESTINATION ${CSP_RUNTIME_INSTALL_SUBDIR} | ||
| LIBRARY DESTINATION lib/ | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.