Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| version: nightly | ||
| # CRITICAL: Lock to a specific stable version (e.g., 1.2.0) | ||
| # instead of the unstable 'nightly'. Replace with the project's supported version. | ||
| version: '1.2.0' |
There was a problem hiding this comment.
Bug: Hardcoded Foundry version appears to be placeholder text
The Foundry version is hardcoded to 1.2.0 with a comment that reads "Replace with the project's supported version." This appears to be placeholder template code that wasn't completed before committing. The comment explicitly indicates this value should be replaced with the actual version the project supports, not left as the example value.
| branches: | ||
| - master # Run on push to master branch | ||
| - develop # Optional: Include development branches | ||
| pull_request: # CRITICAL: Ensure tests run when a PR is opened/updated |
There was a problem hiding this comment.
Bug: Pull request trigger missing branch filter
The pull_request trigger is configured without a branches filter, while the push trigger restricts to master and develop branches. This creates an inconsistency where pull requests to any branch will trigger tests, but direct pushes only trigger on specific branches. Either the pull_request trigger should also specify branch restrictions, or the configuration intent needs clarification.
1 participant
Note
Updates the Tests workflow to run on push/PR, pin Foundry to 1.2.0, add caching, and standardize test execution.
.github/workflows/Tests.yml):master/developand onpull_request.actions/checkout@v4with recursive submodules.foundry-rs/foundry-toolchain@v1toversion: '1.2.0'.actions/cache@v4for~/.foundry/cache,./cache, and~/.cargo/bin/.forge test -vv(reduced verbosity from-vvv).Written by Cursor Bugbot for commit cebfa61. This will update automatically on new commits. Configure here.