Update Tests.yml #14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,44 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master # Run on push to master branch | ||
| - develop # Optional: Include development branches | ||
| pull_request: # CRITICAL: Ensure tests run when a PR is opened/updated | ||
|
|
||
| jobs: | ||
| check: | ||
| name: Foundry Tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Repository and Submodules | ||
| # Use the latest stable version of the checkout action (v4) | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| # Ensure recursive checkout for external dependencies (e.g., libraries like OpenZeppelin) | ||
| submodules: recursive | ||
|
|
||
| - name: Install Foundry Toolchain | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
| with: | ||
| # CRITICAL: Lock to a specific stable version (e.g., 1.2.0) | ||
| # instead of the unstable 'nightly'. Replace with the project's supported version. | ||
| version: '1.2.0' | ||
|
There was a problem hiding this comment. Bug: Hardcoded Foundry version appears to be placeholder textThe Foundry version is hardcoded to |
||
|
|
||
| - name: Cache Dependencies | ||
| # Cache artifacts like compiled contracts, libraries, and external repos (.git) to speed up subsequent runs | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.foundry/cache | ||
| ./cache | ||
| ~/.cargo/bin/ | ||
| key: ${{ runner.os }}-${{ hashFiles('foundry.toml') }}-${{ hashFiles('lib/**/foundry.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}- | ||
|
|
||
| - name: Run Tests | ||
| # Run standard tests. Use '-vv' (two v's) for typical detailed output on failure. | ||
| # Use 'forge test' only, unless specific optimization is needed. | ||
| run: forge test -vv | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Pull request trigger missing branch filter
The
pull_requesttrigger is configured without abranchesfilter, while thepushtrigger restricts tomasteranddevelopbranches. This creates an inconsistency where pull requests to any branch will trigger tests, but direct pushes only trigger on specific branches. Either thepull_requesttrigger should also specify branch restrictions, or the configuration intent needs clarification.