Repository navigation
fix(tv): fast seek-bar scrubbing, Start Over starts from the beginning - #122
Merged
Merged
Conversation
…beginning Holding Left/Right on the seek bar fired a native seek per key repeat and only moved the bar once each seek finished, so it crawled. Left/Right now scrub: the target and preview move immediately, the step grows while the key is held (10s, then 30s, 1m, 2m), and one seek fires once input settles. Start Over sent no start_position, because the request dropped any value that was not positive, and the server reads an omitted start_position as "resume". Start Over now sends an explicit 0, and the request keeps it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seek bar is slow when holding Left/Right
Each key repeat fired a native seek, and the bar moved only after that seek finished, so holding the key crawled.
Left/Right now scrub instead:
playerSeekHoldStep). Releasing resets it.Seek preview drifted away from the thumb
The time bubble was placed as if it were always 176 px wide (a trickplay tile) and measured against the full bar width. A bare timecode, which is what every title without trickplay shows, sat about 50 px behind the thumb and drifted further toward the ends. It now lays out from its real width, centred on the thumb's position along the inset track and clamped to the bar (
seekPreviewLeft, with tests).Start Over resumed instead of starting over
The start request dropped any
start_positionthat wasn't positive. The server reads an omittedstart_positionas "resume where this profile left off", so Start Over, which sent none, always resumed. Start Over now sends an explicit0, and the request builder keeps any non-null value. Omitting it still means resume.Testing
dart analyze lib test: no issuesflutter test(prairie_core): 199 passed, with new tests for the hold-step curve and the zero start position.🤖 Generated with Claude Code