Fix GitHub Actions build workflow#14
Merged
Merged
Conversation
Use MinoruSekine/setup-scoop action instead of manual PowerShell commands for cleaner and more reliable Windows dependency setup.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitHub Actions build workflow to fix issues with the Windows build process. The PR replaces manual Scoop installation commands with a dedicated GitHub Action and ensures the PyInstaller spec file path is correctly referenced throughout the workflow.
Changes:
- Replace manual PowerShell Scoop installation with
MinoruSekine/setup-scoop@v4.0.2action - Remove redundant
if: runner.os == 'Windows'condition (already in Windows-only job)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| install_scoop: true | ||
| buckets: extras | ||
| apps: makensis |
There was a problem hiding this comment.
The Scoop package name should be "nsis", not "makensis". While "makensis" is the name of the executable installed by the NSIS package, the Scoop package itself is called "nsis". Change "makensis" to "nsis" in the apps list.
Suggested change
| apps: makensis | |
| apps: nsis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/Wordweaver.spec) that the build workflow was referencingMinoruSekine/setup-scoop@v4.0.2action for cleaner Windows buildsTest plan