Skip to content

Fix GitHub Actions build workflow #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrestonHager merged 1 commit into from
Jan 18, 2026
Merged

Fix GitHub Actions build workflow #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/python-app-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ jobs:
run: |
uv sync --extra dev
- name: Install Windows dependencies
run: |
iwr -useb get.scoop.sh -outfile 'install.ps1'
.\install.ps1 -RunAsAdmin
scoop update
scoop bucket add extras
scoop install nsis
if: runner.os == 'Windows'
uses: MinoruSekine/setup-scoop@v4.0.2
with:
install_scoop: true
buckets: extras
apps: makensis
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Scoop package name should be "nsis", not "makensis". While "makensis" is the name of the executable installed by the NSIS package, the Scoop package itself is called "nsis". Change "makensis" to "nsis" in the apps list.

Suggested change
apps: makensis
apps: nsis

Copilot uses AI. Check for mistakes.
scoop_update: true
update_path: true
- name: Build executable
run: |
uv run python -m PyInstaller src/Wordweaver.spec
Expand Down