Test Bunny command rerun after failed check#53
Conversation
✅ Bunny Review CompletedTip Review posted. The specimen has left the observation table.
|
🐰 Bunny ReviewBunny Merge Signal: Do Not MergeCaution DO NOT MERGE
Note Mode: 🧭 Specimen Summary
🔎 Isolated Defects
✅ Resolved Since Last Review
🧹 Nitpicks
🤖 Copy prompt for isolated Bunny findings✅ Control Checks
🧪 Observations
🧰 CI Status
|
| @@ -0,0 +1,3 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
🚫 BLOCKING: React crosses into the engine layer
Location: src/engine/bunnyIntentionalArchitectureFailure.ts:1
A fascinatingly compact boundary breach:
src/engineimportsreact, despite AGENTS.md and the architecture guard declaring the engine a React-free product layer. The exportedReact.Fragmentpreserves the contamination as a public engine symbol, coupling product code to UI runtime semantics before any behavior even begins.
Tip
Suggested fix: Return the React-facing value to a feature or app-owned UI module, or replace this engine export with a framework-neutral contract rendered only at the UI edge.
|
/bunny-review full |
| @@ -0,0 +1,3 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
🚫 BLOCKING: React contaminates the engine layer
Location: src/engine/bunnyIntentionalArchitectureFailure.ts:1
The engine layer imports
react, despite the repository contract declaringsrc/engineReact-free. ExportingReact.Fragmentfrom this module forces downstream consumers to inherit a UI-framework dependency from a product-behavior layer. The prior repair contract remains open in exactly the same shape; the boundary violation has not evolved, only persisted.
Tip
Suggested fix: Excise the React import from src/engine; move this UI-facing value to src/features or src/app, or replace it with a framework-neutral engine contract.
Disposable fixture PR to test Bunny Review rerun behavior after an initial failed Bunny status.\n\nIntentional failure:\n- Adds a React import inside src/engine.\n- This violates Marinara architecture rules and should fail required CI and/or Bunny review.\n\nAfter the first Bunny Review status fails, post /bunny-review full to verify the slash-command dispatcher starts a new trusted Bunny run from the failed state.