Skip to content

Test Bunny command rerun after failed check #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Promansis wants to merge 1 commit into
base: refactor
Choose a base branch
from
+3 −0
Open

Test Bunny command rerun after failed check #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/engine/bunnyIntentionalArchitectureFailure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import React from "react";

Check failure on line 1 in src/engine/bunnyIntentionalArchitectureFailure.ts

View workflow job for this annotation

GitHub Actions / Frontend, Architecture, and Organization 

'react' import is restricted from being used. Engine code must stay UI-framework independent

@github-actions github-actions Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 BLOCKING: React crosses into the engine layer

Location: src/engine/bunnyIntentionalArchitectureFailure.ts:1

A fascinatingly compact boundary breach: src/engine imports react, despite AGENTS.md and the architecture guard declaring the engine a React-free product layer. The exported React.Fragment preserves the contamination as a public engine symbol, coupling product code to UI runtime semantics before any behavior even begins.

Tip

Suggested fix: Return the React-facing value to a feature or app-owned UI module, or replace this engine export with a framework-neutral contract rendered only at the UI edge.

@github-actions github-actions Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 BLOCKING: React contaminates the engine layer

Location: src/engine/bunnyIntentionalArchitectureFailure.ts:1

The engine layer imports react, despite the repository contract declaring src/engine React-free. Exporting React.Fragment from this module forces downstream consumers to inherit a UI-framework dependency from a product-behavior layer. The prior repair contract remains open in exactly the same shape; the boundary violation has not evolved, only persisted.

Tip

Suggested fix: Excise the React import from src/engine; move this UI-facing value to src/features or src/app, or replace it with a framework-neutral engine contract.


export const bunnyIntentionalArchitectureFailure = React.Fragment;
Loading