Search many locations for unqualified dot program#21
Open
chadmiller-saq wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Env '-P' is not widely supported. Awaiting a better fix. |
If the name of the dot executable is not qualified with a full path, we should search through some likely locations for it. Use the 'env' program with some likely paths to search through. (A better way to know where to search would be to get the path from the user's environment, but the javascript runtime seems to scour that away.) If we fail to complete running, tell the user what the problem probably is. From env man page, `An exit status of 127 indicates that utility could not be found.` Closes: QAMichaelPeng#7 Closes: QAMichaelPeng#20
The "-P" parameter is a BSDism, and isn't available in GNU env. This works because PATH is treated specially and is taken out and used internally inside the env program, in addition to sending it to the child program as an environment variable.
chadmiller-saq
force-pushed
the
fix-path-search
branch
from
e747dff to
72c6897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the name of the dot executable is not qualified with a full path, we should search through some likely locations for it. Use the 'env' program with some likely paths to search through.
(A better way to know where to search would be to get the path from the user's environment, but the javascript runtime seems to scour that away.)
If we fail to complete running, tell the user what the problem probably is. From env man page,
An exit status of 127 indicates that utility could not be found.Closes: #7
Closes: #20