Repository navigation
chore(lint): enable unawaited_futures, cancel_subscriptions, close_sinks and avoid_void_async (#1241) - #1252
Merged
Merged
Conversation
…nks and avoid_void_async (#1241)
github-actions
Bot
added
tests
- unawaited() where a future is dropped on purpose: cleanup in catch and finally blocks, socket pipes in the SSH tunnel, the zone in main, and dialogs opened by tests. - The MCP socket host closed only the incoming side of a session; the outgoing controller is now closed too. - Fake process streams in tests live for the whole test; their ignores say so.
ZhuchkaTriplesix
marked this pull request as ready for review
October 9, 2026 13:53
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1241
Rules
unawaited_futures,cancel_subscriptions,close_sinksandavoid_void_asyncare on inanalysis_options.yaml.What they flagged (35 places) and how they are fixed
unawaited(...)): cleanup incatch/finallyblocks of the SSH tunnel manager, its socket pipes, the pool lock's error guard, the Mongo open map, and the zone inmain.unawaited. Fake process streams that live for the whole test keep an ignore with the reason above it.cancel_subscriptionsandavoid_void_asyncflagged nothing.