Repository navigation
fix(erd): PNG capture state, Fit with notes, note outline in exports - #1299
Merged
Merged
Conversation
…note outline - The current-theme PNG is a screenshot: a picked relation and the tables marked for a group are cleared for the capture and restored after it. - Fit, the first fit and the PNG size cap use the canvas with its notes, so a note placed away from the cards is in view. - A note without a colour takes its outline from the export palette (the current theme's border), not a fixed light grey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the ER diagram interface review.
#cbd5e1outline. It now uses the export palette's border (the current theme's border when exports use the current theme).Tests:
test/features/erd/erd_ui_review_fixes_test.dart— a note at (2600, 1800) is inside the viewport after the first fit; the saved PNG is written while no focus column or Group button is on screen, and both are back afterwards; the neutral outline is#cbd5e1in the light palette and the theme's border otherwise.Not in this PR: grouping scattered tables (the frame covers unrelated cards) — a behaviour decision, asked separately.