Skip to content

feat(erd): a new group gathers its tables when its frame would cover other cards - #1300

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
fix/erd-group-gather
Oct 10, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
fix/erd-group-gather

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Follow-up to #1282, from the interface review (item 3), decided: gather the group's tables.

Problem: marking tables far apart and grouping them drew a frame over every card between them. Only Auto layout kept a group together, and it also drops every manual position.

Now: when the frame of a new group — or of a group a table was just added to — would cover a card that is not a member, the group's tables are packed into one block (ErdLayout.gather):

  • members keep their reading order (top to bottom, left to right) in a near-square grid with room for the edges between them;
  • the block goes at the first member's place, else at the next member's, else to the right of every other card, wherever its frame covers no other card;
  • cards that are not members never move, and a toast says that the tables were moved together;
  • attached notes follow their tables;
  • when the frame is already clear nothing moves, so an arrangement the user made is not reshuffled.

Tests: ErdLayout.frameCoversOthers / gather in test/core/erd/erd_groups_test.dart (detection, block clear of others and others unchanged, far-right fallback, no-op cases) and a widget test in test/features/erd/erd_groups_view_test.dart (users + tags around orders: orders keeps its place, the two end up together, the toast shows).

…other cards (#1282)

Marked tables far apart gave a frame over everything between them. When
the frame of a new group (or of a group a table was added to) covers a
card that is not a member, the members are packed into one block, at the
first member place where it is free or to the right of the other cards.
Other cards never move; a toast says what happened. Auto layout and a
group whose frame is already clear are unchanged.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 166cc10 into dev Oct 10, 2026
15 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the fix/erd-group-gather branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant