Repository navigation
feat(erd): a new group gathers its tables when its frame would cover other cards - #1300
Merged
Merged
Conversation
…other cards (#1282) Marked tables far apart gave a frame over everything between them. When the frame of a new group (or of a group a table was added to) covers a card that is not a member, the members are packed into one block, at the first member place where it is free or to the right of the other cards. Other cards never move; a toast says what happened. Auto layout and a group whose frame is already clear are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1282, from the interface review (item 3), decided: gather the group's tables.
Problem: marking tables far apart and grouping them drew a frame over every card between them. Only Auto layout kept a group together, and it also drops every manual position.
Now: when the frame of a new group — or of a group a table was just added to — would cover a card that is not a member, the group's tables are packed into one block (
ErdLayout.gather):Tests:
ErdLayout.frameCoversOthers/gatherintest/core/erd/erd_groups_test.dart(detection, block clear of others and others unchanged, far-right fallback, no-op cases) and a widget test intest/features/erd/erd_groups_view_test.dart(users + tags around orders: orders keeps its place, the two end up together, the toast shows).