Fix more percritic in 00_SIGNALduino.pm#1148
Draft
sidey79 wants to merge 20 commits into
Draft
Conversation
fileopen and sleep critic 5 fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 88.92% 89.49% +0.56%
==========================================
Files 43 43
Lines 2466 2466
Branches 170 170
==========================================
+ Hits 2193 2207 +14
+ Misses 119 105 -14
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Sehe ich das richtig, dieser PR ist auch noch offen mit einem Review oder kommt hier noch mehr hinzu? |
Contributor
Author
|
Ja, da ich an den Fileopen Dingen was verändert habe, muss das noch in echt getestet werden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileopen and sleep critic 5 fixed
What is the current behavior?
(You can also link to an open issue here, if this describes the current behavior)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: