Skip to content

Fix more percritic in 00_SIGNALduino.pm #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sidey79 wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Fix more percritic in 00_SIGNALduino.pm #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fa2ece4
00_SIGNALduino.pm
sidey79 Jan 9, 2023
0a4681b
Update Versiondate
actions-user Jan 9, 2023
6ce8443
Merge branch 'master' into master_critic
sidey79 Jan 21, 2023
30a5bd6
Update Versiondate
actions-user Jan 21, 2023
6dd7f21
Merge branch 'master' into master_critic
HomeAutoUser Jan 23, 2023
3f9c3f6
Update Versiondate
actions-user Jan 23, 2023
b3815c8
Merge branch 'master' into master_critic
HomeAutoUser Feb 2, 2023
63981f4
Update Versiondate
actions-user Feb 2, 2023
0663ab4
Merge branch 'master' into master_critic
sidey79 May 18, 2023
871b60e
Update Versiondate
actions-user May 18, 2023
0f69590
Merge branch 'master' into master_critic
sidey79 Jul 20, 2023
863c88f
Update Versiondate
actions-user Jul 20, 2023
3de09c0
Merge branch 'master' into master_critic
sidey79 Aug 14, 2023
25299f1
Update Versiondate
actions-user Aug 14, 2023
115b1f8
Merge branch 'master' into master_critic
sidey79 Aug 15, 2023
622425b
Update Versiondate
actions-user Aug 15, 2023
22dcf3c
Merge branch 'master' into master_critic
sidey79 Jan 2, 2024
82ef30e
Update Versiondate
actions-user Jan 2, 2024
cbac847
Merge branch 'master' into master_critic
sidey79 Mar 9, 2024
295cb07
Update Versiondate
actions-user Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions FHEM/00_SIGNALduino.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# $Id: 00_SIGNALduino.pm 3.5.6 2024-01-06 16:07:53Z elektron-bbs $
# $Id: 00_SIGNALduino.pm 3.5.6 2024-03-09 15:51:45Z sidey79 $
# v3.5.6 - https://github.com/RFD-FHEM/RFFHEM/tree/master
# The module is inspired by the FHEMduino project and modified in serval ways for processing the incoming messages
# see http://www.fhemwiki.de/wiki/SIGNALDuino
Expand Down Expand Up @@ -30,7 +30,7 @@ eval {use Data::Dumper qw(Dumper);1};
use constant HAS_JSON => defined eval { require JSON; JSON->import; };

eval {use Scalar::Util qw(looks_like_number);1};
eval {use Time::HiRes qw(gettimeofday);1} ;
eval {use Time::HiRes qw(gettimeofday usleep);1} ;
eval {use FHEM::Core::Timer::Helper;1 } ;

use lib::SD_Protocols;
Expand All @@ -42,7 +42,7 @@ use List::Util qw(first);


use constant {
SDUINO_VERSION => '3.5.6+20231214', # Datum wird automatisch bei jedem pull request aktualisiert
SDUINO_VERSION => '3.5.6+20230815', # Datum wird automatisch bei jedem pull request aktualisiert
SDUINO_INIT_WAIT_XQ => 1.5, # wait disable device
SDUINO_INIT_WAIT => 2,
SDUINO_INIT_MAXRETRY => 3,
Expand Down Expand Up @@ -533,11 +533,12 @@ sub SIGNALduino_avrdude {

local $/=undef;
if (-e $logFile) {
open FILE, $logFile;
open my $Log_FH, '>', $logFile or croak qq[Can't open $logFile];

$hash->{helper}{avrdudelogs} .= "--- AVRDUDE ---------------------------------------------------------------------------------\n";
$hash->{helper}{avrdudelogs} .= <FILE>;
$hash->{helper}{avrdudelogs} .= $Log_FH;
$hash->{helper}{avrdudelogs} .= "--- AVRDUDE ---------------------------------------------------------------------------------\n\n";
close FILE;
close $Log_FH;
} else {
$hash->{helper}{avrdudelogs} .= "WARNING: avrdude created no log file\n\n";
readingsSingleUpdate($hash,'state','FIRMWARE UPDATE with error',1);
Expand Down Expand Up @@ -3098,7 +3099,7 @@ sub SIGNALduino_SimpleWrite {
syswrite($hash->{DIODev}, $msg) if($hash->{DIODev});

# Some linux installations are broken with 0.001, T01 returns no answer
select(undef, undef, undef, 0.01);
usleep 10000;
}

############################# package main
Expand Down
2 changes: 1 addition & 1 deletion controls_signalduino.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
UPD 2024-01-06_20:21:35 240687 FHEM/00_SIGNALduino.pm
UPD 2024-03-09_16:51:19 240721 FHEM/00_SIGNALduino.pm
UPD 2023-01-06_12:08:43 20082 FHEM/10_FS10.pm
UPD 2024-01-03_23:05:39 27250 FHEM/10_SD_GT.pm
UPD 2023-01-01_18:10:40 25403 FHEM/10_SD_Rojaflex.pm
Expand Down