Skip to content

01a0672f - test(history): pin inbound transfers labelled as Kauf - #967

Merged
TaprootFreak merged 3 commits into
stagingfrom
test/history-transfer-label-baselines
Sep 7, 2026
Merged

01a0672f - test(history): pin inbound transfers labelled as Kauf#967
TaprootFreak merged 3 commits into
stagingfrom
test/history-transfer-label-baselines

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
Pins the current history titles: inbound REALU from an external wallet is labelled Kauf. A follow-up PR will change the same screenshot to Empfangen.

DE:
Hält die heutigen History-Titel fest: eingehende REALU von einer fremden Wallet heissen Kauf. Ein Folge-PR ändert denselben Screenshot zu Empfangen.

Details

No production-code change. One golden (transaction_history_transfer_labels) with four rows (100 in, 10 in, 10 out, 20 out). PNGs come from golden-regenerate.yaml on the self-hosted runner — not generated locally.

The parked fix is #965 / feat/history-transfer-labels. After this merge it will be rebased so GitHub shows the pixel before/after on this file.

TaprootFreakAI and others added 3 commits September 6, 2026 22:15
Golden of the current direction-only titles so a follow-up PR can
replace the same PNG when inbound-from-external becomes Empfangen.
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 6, 2026 20:27
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 1 review pass.
Pins the current history titles: inbound REALU from an external wallet is labelled Kauf. A follow-up PR will change the same screenshot to Empfangen.

DE:
Bereit nach 1 Review-Durchlauf.
Hält die heutigen History-Titel fest: eingehende REALU von einer fremden Wallet heissen Kauf. Ein Folge-PR ändert denselben Screenshot zu Empfangen.

Details

Test-only. Golden transaction_history_transfer_labels: +100 Kauf, +10 Kauf (the bug), −10 Verkauf, −20 Verkauf. No production-code change.

Open comments: none.
Mergeable: MERGEABLE at 0bfc266. Analyze & Test, Visual Regression, BitBox quirks audit green. Maestro skipped (no tier3:full).

After merge, rebase the parked fix (former #965, branch feat/history-transfer-labels) so GitHub diffs this PNG Kauf → Empfangen.

@TaprootFreak
TaprootFreak merged commit 616ebec into staging Sep 7, 2026
11 checks passed
@TaprootFreak
TaprootFreak deleted the test/history-transfer-label-baselines branch September 7, 2026 05:46
TaprootFreak pushed a commit that referenced this pull request Sep 7, 2026
#969)

EN:
Labels inbound REALU from an external wallet as Empfangen instead of
Kauf, using the API category. The history screenshot diffs against the
baseline from #967.

DE:
Beschriftet eingehende REALU von einer fremden Wallet als Empfangen
statt Kauf, anhand der API-Kategorie. Der History-Screenshot diffed
gegen die Baseline aus #967.

<details>
<summary>Details</summary>

Same four rows as #967. The shared golden
`transaction_history_transfer_labels` changes +10 from Kauf to Empfangen
and −10 from Verkauf to Gesendet. Brokerbot rows stay Kauf/Verkauf.

Follows closed #965 (fork head could not be force-pushed after the
rebase).

</details>

---------

Co-authored-by: Blume1977 <jana.ruettimann@dfx.swiss>
Co-authored-by: TaprootFreakAI <315477232+TaprootFreakAI@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants