Adds ISubscription and ISubscriptionRead - #53
Conversation
| * @param roomId the id of the room | ||
| * @returns the subscription | ||
| */ | ||
| getByRoomId(roomId: string): Promise<IterableIterator<ISubscription>>; |
There was a problem hiding this comment.
Can you help me understand why you're returning an IterableIterator here when you're only returning one? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols
There was a problem hiding this comment.
the comment is wrong, it's supposed to return an Iterable of ISubscription
There was a problem hiding this comment.
Okay, so maybe the one above it should read Gets all of the subscriptions which are for the provided room. as the gets a subscription is a little misleading as well.
|
This gets the room subscriptions right? So returns all users subscriptions to a room? Would RoomSubscription be more clear from an outside developers perspective? |
|
@geekgonecrazy I think I would tend to agree as well, |
|
Yes not to mention meteor subscriptions etc. It would be great from an apps perspective if that was never an issue that ever needed clarified |
|
And should we then also change |
|
Please move this Pull Request to the repository https://github.com/RocketChat/Rocket.Chat.Apps-engine since we moved this code to https://github.com/RocketChat/Rocket.Chat.Apps-engine/tree/master/src/definition Thanks |
4 participants
No description provided.