Skip to content

chore: Update Emoji library#30796

Closed
Hares27 wants to merge 3 commits intoRocketChat:developfrom
Hares27:Hares27/issue#24917
Closed

chore: Update Emoji library#30796
Hares27 wants to merge 3 commits intoRocketChat:developfrom
Hares27:Hares27/issue#24917

Conversation

@Hares27
Copy link
Copy Markdown

@Hares27 Hares27 commented Oct 28, 2023

Changed the css sprite filenames to start with joypixels- as opposed to emojione-
Changed the class names to contain joypixels as opposed to emojione
Changed the import statements to use emoji-toolkit as opposed to emojione
package.json to contain emoji-toolkit and emoji-assets

@Hares27 Hares27 requested review from a team as code owners October 28, 2023 13:29
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 28, 2023

⚠️ No Changeset found

Latest commit: 8404ec8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Oct 28, 2023

please check the pr title ,changeset, and I think you are missing something on package.json + yarn.lock

@Hares27 Hares27 changed the title updated emojione to joypixels Update Emoji library Oct 29, 2023
@Hares27
Copy link
Copy Markdown
Author

Hares27 commented Oct 29, 2023

Hello @ggazzo , I have changed the pr title and modified the package.json and yarn.lock. Please let me know if I am missing anything

@ggazzo ggazzo changed the title Update Emoji library chore: Update Emoji library Oct 30, 2023
This was referenced Dec 1, 2023
@Himanshu-kiran
Copy link
Copy Markdown

Issue has not been merged yet so I would like to resolve this issue.

@danielpotthast
Copy link
Copy Markdown

@Himanshu-kiran Just go ahead, you don’t need to ask for permission to start your own PR.

Meanwhile this PR won’t add any new emojis because it’s using the old emojione assets package. I’ve tried to update this as well but Rocket.Chat uses a hacky solution (generateEmojiIndex.mjs) to populate their emoji selector. And since Rocket.Chat is starting to push users more and more into a paid subscription, I’m not willing to invest more time. 🫠

@engelgabriel
Copy link
Copy Markdown
Member

Closing this PR in favor of #39411, where we’re replacing Emojione with native Unicode emojis.

It’s still a draft, and we’d love help from the community to get it across the finish line 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants