Conversation
|
|
|
|
please check the pr title ,changeset, and I think you are missing something on package.json + yarn.lock |
|
Hello @ggazzo , I have changed the pr title and modified the package.json and yarn.lock. Please let me know if I am missing anything |
|
Issue has not been merged yet so I would like to resolve this issue. |
|
@Himanshu-kiran Just go ahead, you don’t need to ask for permission to start your own PR. Meanwhile this PR won’t add any new emojis because it’s using the old emojione assets package. I’ve tried to update this as well but Rocket.Chat uses a hacky solution ( |
|
Closing this PR in favor of #39411, where we’re replacing Emojione with native Unicode emojis. It’s still a draft, and we’d love help from the community to get it across the finish line 🙌 |
Changed the css sprite filenames to start with joypixels- as opposed to emojione-
Changed the class names to contain joypixels as opposed to emojione
Changed the import statements to use emoji-toolkit as opposed to emojione
package.json to contain emoji-toolkit and emoji-assets