chore: insert emojis as UTF-8 Unicode instead of shortname syntax#39432
Draft
Copilot wants to merge 13 commits intoremove-joypixelfrom
Draft
chore: insert emojis as UTF-8 Unicode instead of shortname syntax#39432Copilot wants to merge 13 commits intoremove-joypixelfrom
Copilot wants to merge 13 commits intoremove-joypixelfrom
Conversation
Replace the emojione-based emoji rendering with a new native Unicode emoji module. Uses emojibase for shortname-to-unicode mapping and renders emojis as native characters with a standard emoji font stack. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Delete entire emoji-emojione module (CSS sprites, config, templates) - Remove emojione sprite PNGs (~6.4MB of assets) - Update all imports to use the new emoji-native module - Replace emojione.shortnameToUnicode with emojibase-backed utility - Update emoji picker, tone selector, and parser for native rendering - Update federation-matrix to use emojibase for emoji conversion - Remove emoji-toolkit from pdf-worker, render unicode directly - Remove emojione type declarations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove emojione, emoji-toolkit, emojione-assets from all packages - Add emojibase and emojibase-data as replacements - Update eslint and stylelint ignore patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update federation e2e tests to use .emoji class instead of .emojione - Update reaction unit test description Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
…typed shortname completion Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove emojione in favor of native emojis
chore: insert emojis as UTF-8 Unicode instead of shortname syntax
Mar 6, 2026
e0ef711 to
fdc9e41
Compare
ff64c7a to
2dfc482
Compare
549836f to
3e18036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emoji insertion via the picker and autocomplete was using
:shortname:format. Native emojis should be inserted as their UTF-8 Unicode characters; custom emojis continue to use:shortname:.Changes
MessageBox.tsx): Resolves the selected emoji name againstemoji.list— inserts UTF-8 for native,:shortname:for custom/unknown:trigger,ComposerPopupProvider.tsx):getValuereturns the Unicode character for native emojis;prefixset to''to prevent the trigger:from being double-prependedMessageBox.tsx):keyuphandler auto-converts a fully typed:emoji:shortname to UTF-8 the moment the closing:is pressed — no-ops on custom emojis and unknown shortnames🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.