chore: remove emojione in favor of native emojis#39411
chore: remove emojione in favor of native emojis#39411sampaiodiego wants to merge 19 commits intodevelopfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d3b9fcc to
095c8c3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #39411 +/- ##
===========================================
+ Coverage 70.55% 70.94% +0.39%
===========================================
Files 3271 3272 +1
Lines 116782 118248 +1466
Branches 21090 21077 -13
===========================================
+ Hits 82393 83889 +1496
+ Misses 32338 32311 -27
+ Partials 2051 2048 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@copilot when inserting an emoji using the picker or autocomplete, use the UTF-8 encoding unless it's a custom emoji, |
MartinSchoeler
left a comment
There was a problem hiding this comment.
Whenever the user adds an emoji using the emoji picker, the result should be an unicode character being added to the message composer, only show the shortcode as fallback for custom emojis or emojis that don't have an unicode counterpart
Steps to reproduce:
Open emoji picker
Select an emoji
Expected behavior:
An unicode emoji character should be added. (Example 🙈)
Actual behavior:
A shortname is added. (Example 🙈)
|
e0ef711 to
fdc9e41
Compare
ff64c7a to
2dfc482
Compare
Replace the emojione-based emoji rendering with a new native Unicode emoji module. Uses emojibase for shortname-to-unicode mapping and renders emojis as native characters with a standard emoji font stack. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Delete entire emoji-emojione module (CSS sprites, config, templates) - Remove emojione sprite PNGs (~6.4MB of assets) - Update all imports to use the new emoji-native module - Replace emojione.shortnameToUnicode with emojibase-backed utility - Update emoji picker, tone selector, and parser for native rendering - Update federation-matrix to use emojibase for emoji conversion - Remove emoji-toolkit from pdf-worker, render unicode directly - Remove emojione type declarations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove emojione, emoji-toolkit, emojione-assets from all packages - Add emojibase and emojibase-data as replacements - Update eslint and stylelint ignore patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update federation e2e tests to use .emoji class instead of .emojione - Update reaction unit test description Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…hortcode (#39474) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
549836f to
3e18036
Compare
Replace Emojione with Native Unicode Emojis
Summary
This PR removes the dependency on Emojione and transitions Rocket.Chat to use native Unicode emojis across the platform. All emojis will now be stored and processed as standard Unicode characters directly in the database.
Why this change
Emojione introduced an additional abstraction layer (shortcodes + image mapping) that increases complexity, impacts performance, and limits interoperability with modern protocols.
By adopting native Unicode emojis, we align Rocket.Chat with current standards used across messaging platforms and protocols.
Performance Improvements
Improved Compatibility (Matrix & Open Protocols)
Developer & Maintenance Benefits
Migration Notes
Result
A simpler, faster, and more interoperable emoji system that:
CORE-1980