Skip to content

chore: insert unicode emoji from picker and autocomplete instead of shortcode#39474

Merged
ggazzo merged 2 commits intoremove-joypixelfrom
copilot/sub-pr-39411-again
Mar 9, 2026
Merged

chore: insert unicode emoji from picker and autocomplete instead of shortcode#39474
ggazzo merged 2 commits intoremove-joypixelfrom
copilot/sub-pr-39411-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

Selecting an emoji from the picker or : autocomplete was inserting the shortcode (:see_no_evil:) instead of the unicode character (🙈). Custom emojis without a unicode counterpart should continue using the shortcode format.

Changes

  • MessageBox.tsx: Emoji picker callback now resolves emoji.list[':name:']?.unicode before inserting; falls back to :name: for custom/unknown emojis
  • ComposerPopupProvider.tsx: : trigger autocomplete getValue returns unicode when available, full :shortcode: otherwise; prefix set to '' (was implicitly ':') to avoid double-colon insertion
// Before
chat.emojiPicker.open(ref, (emoji) => chat.composer?.insertText(` :${emoji}: `));

// After
chat.emojiPicker.open(ref, (emojiName) => {
  const emojiEntry = emoji.list[`:${emojiName}:`];
  const text = emojiEntry?.unicode ? ` ${emojiEntry.unicode} ` : ` :${emojiName}: `;
  chat.composer?.insertText(text);
});

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Mar 9, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: 7443857

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…ortcode

Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove emojione in favor of native emojis chore: insert unicode emoji from picker and autocomplete instead of shortcode Mar 9, 2026
@ggazzo ggazzo marked this pull request as ready for review March 9, 2026 17:40
@ggazzo ggazzo requested a review from a team as a code owner March 9, 2026 17:40
@ggazzo ggazzo merged commit a7ad847 into remove-joypixel Mar 9, 2026
2 checks passed
@ggazzo ggazzo deleted the copilot/sub-pr-39411-again branch March 9, 2026 17:41
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

sampaiodiego pushed a commit that referenced this pull request Mar 10, 2026
…hortcode (#39474)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
sampaiodiego pushed a commit that referenced this pull request Mar 11, 2026
…hortcode (#39474)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
MartinSchoeler pushed a commit that referenced this pull request Mar 23, 2026
…hortcode (#39474)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
MartinSchoeler pushed a commit that referenced this pull request Apr 7, 2026
…hortcode (#39474)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants