[Refactor] Centralize automation recommendation ownership - #1357
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Refactor] Centralize automation recommendation ownership#1357roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| 'recommendation_queue_unavailable', | ||
| ); | ||
| } | ||
| await dispatchSetupAutomationRecommendationBatch({ |
Contributor
There was a problem hiding this comment.
The new title hydration only happens through the recommendation SDK commands, but this onboarding path still returns the raw persisted startResult.recommendationBatch. SetupSignedInFlow uses that response to seed listRecommendations directly, so an existing pre-refactor batch with no title bypasses listSetupAutomationRecommendations() and renders candidateId values in the setup step. Hydrate the returned batch (or source it through the SDK read helper) before returning it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The automation recommendation feature introduced in #1321 had policy and lifecycle behavior spread across shared contracts, a large SDK runtime module, and setup command orchestration. Consolidating that ownership gives future recommendation work one server domain and prevents stale scoring workers from replacing a newer recommendation batch.
Impact
There is no intended user-facing behavior change. Recommendation scoring, setup application, manual-run validation, and initial-run dispatch retain their existing behavior, while the feature has clearer ownership and focused regression coverage. The repository pre-push gates pass; package-local SDK ESLint still reports three pre-existing unused-disable warnings in unrelated files.