Skip to content

[Refactor] Centralize automation recommendation ownership #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Refactor] Centralize automation recommendation ownership #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions apps/web/src/app/(onboarding)/setup/StepAutomationRecommendations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@

import { useEffect, useRef, useState } from 'react';
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query';
import {
AUTOMATION_RECOMMENDATION_CATALOG,
type AutomationRecommendationBatch,
} from '@roomote/types';
import type { AutomationRecommendationBatch } from '@roomote/types';
import {
Alert,
AlertDescription,
Expand All @@ -23,12 +20,10 @@ import { getSetupStepDefinition } from './types';

const STEP = getSetupStepDefinition('automation-recommendations');

function candidateTitle(candidateId: string) {
return (
AUTOMATION_RECOMMENDATION_CATALOG.find(
(candidate) => candidate.id === candidateId,
)?.title ?? candidateId
);
function candidateTitle(
recommendation: AutomationRecommendationBatch['recommendations'][number],
) {
return recommendation.title ?? recommendation.candidateId;
}

export function StepAutomationRecommendations({
Expand Down Expand Up @@ -194,7 +189,7 @@ export function StepAutomationRecommendations({
/>
<div className="min-w-0 flex-1">
<p className="text-sm font-semibold">
{candidateTitle(recommendation.candidateId)}
{candidateTitle(recommendation)}
</p>
<p className="text-sm text-muted-foreground">
{recommendation.explanation}
Expand Down
266 changes: 80 additions & 186 deletions apps/web/src/trpc/commands/setup-new/index.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading