Conversation
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Fix the Doxygen comment if you get a chance.
The rest is good.
| std::vector<int> hitIDs; ///< Index of the recob::hit objects making up this cluster. Size should match nHits | ||
| std::vector<int> wires; ///< Set of geo::wireIDs contributing hits to this cluster. Size should match nWires |
There was a problem hiding this comment.
They are cosmetic. If present, Doxygen will render the content in monospace, which is custom for variable and code-related names. Doxygen should be able to detect the cross-link either way.
| bool pass_flashtrig = false; ///< Whether this Record passed the Flash Trigger requirement | ||
| SRSBNDFrameShiftInfo sbnd_frames; ///< List of Frame Shift in event in unit [ns] (SBND) | ||
| SRSBNDTimingInfo sbnd_timings; ///< List of Timing Info in event in UNIX timestamp format(SBND) | ||
| std::vector<SRBlip> blips; ///Blips are small O(mm) depositions in LAr, made from recob::hits |
There was a problem hiding this comment.
| std::vector<SRBlip> blips; ///Blips are small O(mm) depositions in LAr, made from recob::hits | |
| std::vector<SRBlip> blips; ///< Blips are small O(mm) depositions in LAr, made from recob::Hit |
|
Updated comments. And all PR should now be corrected. I'll check the compilation + running and comment results in SBNSoftware/sbndcode#871 |
|
You missed the switch from |
|
Ah sorry fixed now |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_15_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
8 participants
Added classes to hold blip information in CAF format.
This results in the normal amount of CAF code duplication and replaces a few std::map and std::set objects in the LArSoft side with vectors.
This PR is independent of the associated ones in sbnobj, sbndcode, and sbncode.