fix(skill,refund): drop the --raw-key pass-through to selat-pay - #187
Merged
Merged
Conversation
selat-pay no longer has a local-key signing path (SELAT-AI/selat-pay#92), so 'selat skill run --raw-key' and 'selat refund --raw-key' would forward an option it rejects. Remove the override, its help/usage text, and the argv push in skill-registry. One test now guards that compileStep never emits --raw-key even if a stale caller passes the old override. Tests: 584/584. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
SELAT-DEV
added a commit
that referenced
this pull request
Sep 17, 2026
@selat-ai/selat-pay floor ^0.11.2 -> ^0.12.0 (drops --raw-key; pulls @circle-fin/x402-batching 3.5.0). Pairs with #187. Co-authored-by: Karen Sheng <ksherlocked@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
SELAT-DEV
added a commit
to SELAT-AI/selat-plugins
that referenced
this pull request
Sep 18, 2026
…s --raw-key, covers Arc (#112) * docs(selat): SKILL.md no longer describes a --raw-key mode selat-pay drops local-key signing (SELAT-AI/selat-pay#92) and selat-cli drops the pass-through (SELAT-AI/selat-cli#187). The skill now says there is no local-key path and lists two reserved overrides, not three. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: runtime 0.17.5 / 0.26.1 / 0.12.0; plugin 0.1.12; SKILL.md restamped Runtime closure regenerated for the coordinated release that removed local-key signing and put Arc deposits on the Circle CLI: selat-cli 0.17.5, selat-discovery 0.26.1, selat-pay 0.12.0 (both the plugin's hooks-handlers copy and the Hermes copy; documented pins in README / guides / install.md resynced by the script). plugin.json (claude / codex / cursor) and plugins/selat/package.json 0.1.11 -> 0.1.12 so `claude plugin update` actually picks the refresh up. SKILL.md: verify-against stamps -> 0.17.5 / 0.26.1; the no-local-key bullet now covers Arc mainnet (agent-wallet deposit, direct only, needs Circle CLI >= 1.1.1 which `selat init` installs/upgrades automatically). regenerate-selat-runtime-lock.sh: realpath the temp dir. On macOS $TMPDIR is a symlink (/var/folders -> /private/var/folders); npm keyed the lock relative to the unresolved --prefix, so no "node_modules/…" entries existed and the integrity check always failed locally. CI (Linux /tmp) never hit it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Karen Sheng <ksherlocked@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
--raw-keypass-through fromselat skill runandselat refund, plus its help/usage text and theargv.push("--raw-key")inlib/skill-registry.mjs.Why
selat-pay drops local-key signing in SELAT-AI/selat-pay#92 — every signature goes through the Circle Agent Wallet. Once that releases, forwarding
--raw-keywould make selat-pay fail with "unknown option".Tests
test/skill-registry.test.mjs: the three--raw-keyoverride tests collapse into one guard —compileStepnever emits--raw-key, even when a stale caller passes{ rawKey: true }.test/delegating-commands.test.mjs/test/refund.test.mjs: bare-flag passthrough cases re-pointed at--json/--insecure-router.npm test: 584/584.Sequencing
Merge after selat-pay #92 releases, and bump
@selat-ai/selat-payin the same release. Merging earlier is harmless (the flag just stops being forwarded).Not in this PR: the raw-key Arc deposit path in
lib/commands/fund.mjs(resolveArcDepositEnv→ selat-discoverygateway-rawkey.mjs). Circle CLI 1.1.1 now supportsgateway deposit --chain ARC --method direct, so that path can be replaced by the standard CLI route — separate PR pair (discovery first).🤖 Generated with Claude Code