FIX: Have output spec shape verifier working with batched models#75
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 71.83% 71.81% -0.03%
==========================================
Files 86 86
Lines 14902 14903 +1
==========================================
- Hits 10705 10702 -3
- Misses 4197 4201 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Collaborator
|
Please fix the coverage issue. @hanyuone |
Contributor
|
It would be better to squash the commits into one for easier maintaining. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of batching,
y_trueinOutputSpecs are concatenated. The original check for whethery_trueis a valid class no longer works -0 <= spec.y_true < num_classesis syntactic sugar for0 <= spec.y_true and spec.y_true < num_classes, and the output for both comparisons is a boolean tensor, which cannot be directlyanded.This PR fixes this bug, and patches both
create_specs.pyto reflect the output ofself.validate_spec_pair_with_model, which now returns an(is_valid, errors)tuple.