Skip to content

FIX: Have output spec shape verifier working with batched models #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuleisui merged 5 commits into from
Jun 4, 2026
Merged

FIX: Have output spec shape verifier working with batched models #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1267ba
fix: add errors return value to validate_spec_pair_with_model output
hanyuone Jun 4, 2026
85de7d0
fix: have y_true class bounds check work with multi-element bool tensors
hanyuone Jun 4, 2026
073dfd2
test: add notebook for dtype testing purposes
hanyuone Jun 4, 2026
40ae267
fix: same errors fix on VNNLib spec creator
hanyuone Jun 4, 2026
a1098cc
test: remove notebook
hanyuone Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion act/front_end/spec_creator_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,9 @@ def _validate_output_spec_shape(
(is_valid, error_message) tuple
"""
if spec.kind in [OutKind.MARGIN_ROBUST, OutKind.TOP1_ROBUST]:
if not (0 <= spec.y_true < num_classes):
y_true_valid_class = (0 <= spec.y_true).logical_and(spec.y_true < num_classes)

if not y_true_valid_class.all():
return False, f"Class label {spec.y_true} out of range [0, {num_classes})"

elif spec.kind == OutKind.LINEAR_LE:
Expand Down
6 changes: 3 additions & 3 deletions act/front_end/torchvision_loader/create_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ def _validate_and_filter_specs(

for input_spec, output_spec in spec_pairs:
try:
is_valid = self.validate_spec_pair_with_model(
is_valid, errors = self.validate_spec_pair_with_model(
input_spec,
output_spec,
pytorch_model,
Expand All @@ -475,8 +475,8 @@ def _validate_and_filter_specs(
valid_pairs.append((input_spec, output_spec))
else:
logger.debug(
f"Spec pair validation failed: "
f"{input_spec.kind}, {output_spec.kind}"
f"Spec pair validation failed: {input_spec.kind}, {output_spec.kind}, with errors:\n"
f"{"\n".join(errors)}"
)

except Exception as e:
Expand Down
6 changes: 3 additions & 3 deletions act/front_end/vnnlib_loader/create_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def _validate_and_filter_specs(

for input_spec, output_spec in spec_pairs:
try:
is_valid = self.validate_spec_pair_with_model(
is_valid, errors = self.validate_spec_pair_with_model(
input_spec,
output_spec,
pytorch_model,
Expand All @@ -292,8 +292,8 @@ def _validate_and_filter_specs(
valid_pairs.append((input_spec, output_spec))
else:
logger.debug(
f"Spec pair validation failed: "
f"{input_spec.kind}, {output_spec.kind}"
f"Spec pair validation failed: {input_spec.kind}, {output_spec.kind}, with errors:\n"
f"{"\n".join(errors)}"
)

except Exception as e:
Expand Down
Loading