Fix execute-notebooks CI break by aligning MTA pybind bindings with current svf-lib APIs

[Copilot]

execute-notebooks was failing before notebook execution because wheel build broke in pybind/MTA.cpp against current svf-lib headers. The binding code referenced removed/changed MTA APIs (detect and templated analyze methods) and failed to compile/link.

• API compatibility: MTA.detect

  • Restored Python-facing MTA.detect() by adding a PublicMTA::detect() wrapper that forwards to reportRaces().

• Templated analyze bindings (MHP, LockAnalysis)

  • Replaced direct method-pointer bindings (&Class::analyze) with explicit lambda adapters.
  • Lambdas now call templated analyze(ICFG*, CallGraph*) using graph objects derived from TCT/PTA, matching current upstream signatures.

• Scope

  • Change is isolated to pybind/MTA.cpp; no workflow, notebook, or unrelated binding changes.

.def("analyze", [](MHP& self) {
    TCT* tct = self.getTCT();
    self.analyze(
        tct->getPTA()->getICFG(),
        static_cast<CallGraph*>(tct->getThreadCallGraph())
    );
}, "Analyze entry")

[Copilot]

Pull request overview

This PR updates the SVF-Python multi-thread analysis (MTA) pybind bindings to compile against current svf-lib APIs, restoring the MTA.detect() Python entrypoint and adapting MHP / LockAnalysis bindings to templated analyze(ICFG*, CallGraph*) signatures.

Changes:

• Add PublicMTA::detect() wrapper that forwards to reportRaces() and bind it as MTA.detect().
• Replace direct &Class::analyze bindings for MHP and LockAnalysis with lambda adapters calling the templated analyze(ICFG*, CallGraph*).
• Rename the Python typing stub method LockAnalysis.isProtectedByCommandLock to isProtectedByCommonLock to match the bound API.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pybind/MTA.cpp	Adds an MTA.detect() wrapper and switches MHP/LockAnalysis analyze() bindings to lambda adapters compatible with current svf-lib.
pysvf/pysvf.pyi	Updates the exposed typing stub to reflect the renamed LockAnalysis.isProtectedByCommonLock API.

Comments suppressed due to low confidence (1)

pybind/MTA.cpp:59

• The new analyze() lambda forwards tct->getThreadCallGraph() without checking for null. If the thread call graph hasn’t been built yet, this will pass nullptr into the SVF analyze() overload and may crash. Consider mirroring the existing null check used in the TCT.getThreadCallGraph binding.

        .def("analyze", [](LockAnalysis& self) {
                TCT* tct = self.getTCT();
                self.analyze(tct->getPTA()->getICFG(), static_cast<CallGraph*>(tct->getThreadCallGraph()));
            }, "Analysis entry")

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.