Skip to content

Fix execute-notebooks CI break by aligning MTA pybind bindings with current svf-lib APIs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuleisui merged 3 commits into from
Jul 23, 2026
+12 −5
Merged

Fix execute-notebooks CI break by aligning MTA pybind bindings with current svf-lib APIs #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e213380
Initial plan
Copilot Jul 23, 2026
776f139
Fix MTA pybind API mismatch for notebook CI build
Copilot Jul 23, 2026
b710a6e
Fix typo: isProtectedByCommandLock -> isProtectedByCommonLock
Copilot Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions pybind/MTA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ void bind_multi_thread_analysis(py::module& m) {
public:
using MTA::MTA;
using MTA::runOnModule;
void detect() { reportRaces(); }
};

py::class_<PublicMTA, std::shared_ptr<PublicMTA>>(m, "MTA", "Multi-Thread Analysis class")
Expand All @@ -38,19 +39,25 @@ void bind_multi_thread_analysis(py::module& m) {
}),
py::arg("tct"), "Initialize MHP analysis",
py::keep_alive<1, 2>())
.def("analyze", &MHP::analyze, "Analyze entry")
.def("analyze", [](MHP& self) {
TCT* tct = self.getTCT();
self.analyze(tct->getPTA()->getICFG(), static_cast<CallGraph*>(tct->getThreadCallGraph()));
}, "Analyze entry")
Comment on lines +42 to +45
.def("mayHappenInParallelInst", &MHP::mayHappenInParallelInst,
py::arg("node1"), py::arg("node2"),
"Check if two ICFG nodes may happen in parallel");

py::class_<LockAnalysis, std::shared_ptr<LockAnalysis>>(m, "LockAnalysis", "Lock Set Analysis class")
.def(py::init([](std::shared_ptr<TCT> tct){
return std::make_shared<LockAnalysis>(tct.get());
;})
})
, py::arg("tct"), "Initialize Lock Set analysis",
py::keep_alive<1, 2>())
.def("analyze", &LockAnalysis::analyze, "Analysis entry")
.def("isProtectedByCommandLock", &LockAnalysis::isProtectedByCommonLock,
.def("analyze", [](LockAnalysis& self) {
TCT* tct = self.getTCT();
self.analyze(tct->getPTA()->getICFG(), static_cast<CallGraph*>(tct->getThreadCallGraph()));
}, "Analysis entry")
.def("isProtectedByCommonLock", &LockAnalysis::isProtectedByCommonLock,
py::arg("node1"), py::arg("node2"),
"Check if two ICFG nodes are protected by common locks");

Expand Down
2 changes: 1 addition & 1 deletion pysvf/pysvf.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2076,4 +2076,4 @@ class MHP:
class LockAnalysis:
def __init__(self, tct: 'TCT') -> None: ...
def analyze(self) -> None: ...
def isProtectedByCommandLock(self, icfg_node_id1: int, icfg_node_id2: int) -> bool: ...
def isProtectedByCommonLock(self, icfg_node_id1: int, icfg_node_id2: int) -> bool: ...
Loading