Skip to content

Normalize nopre -> QA (+ split AD/Enzyme)#619

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:normalize-nopre-qa
Jun 15, 2026
Merged

Normalize nopre -> QA (+ split AD/Enzyme)#619
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:normalize-nopre-qa

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Part of the fleet-wide nopre/NoPre test-group normalization (policy: standard QA checks live in a canonical QA group on ["lts", "1"], ubuntu-only; pre-incompatible functional tests get their own content-named groups).

Survey result for this repo: the root nopre group was PURE standard QA (JET static analysis only), so it merges into a canonical QA group:

  • test/nopre/test/qa/ (jet_tests.jlqa.jl, content unchanged).
  • test/runtests.jl: dispatches on GROUP == "QA" (activate_nopre_envactivate_qa_env).
  • test/test_groups.toml: [nopre][QA], versions ["lts", "1"] (unchanged), ubuntu-only. The old comment's rationale for keeping the name lowercase (matching a lowercase CI matrix input) no longer applies — the matrix comes straight from this file.
  • .github/workflows/CI.yml: comment updated to name the new group.

Notes:

  • The root QA currently has no Aqua suite; this PR only relocates/renames the existing JET check (adding Aqua here would be an unverified new check — left for a separate PR if wanted).
  • lib/* sublibraries (DataDrivenDMD, DataDrivenLux, DataDrivenSR, DataDrivenSparse) declare no nopre groups (Core only) — per the concurrent sublib-qa pass, this PR intentionally touches the ROOT package only.

Verification: static only (TOML parse of test_groups.toml + qa/Project.toml; Meta.parseall of changed .jl files; Runic check clean). Test suites not run locally — CI should confirm the QA group goes green.

Ignore until reviewed by @ChrisRackauckas.

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Branch reset to a clean implementation off the current default branch: removed unrelated changes from the prior revision (no spurious action/codecov version edits), renamed the dep env test/nopre -> test/qa, and kept the existing JET/Aqua test files in place (no test-logic changes). Static-verified locally: test_groups.toml parses and runtests.jl passes Meta.parseall.

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 15, 2026 05:06
The root nopre group carried only the standard JET static-analysis check, so
it is renamed to the canonical QA group at versions ["lts","1"]. The dep env
test/nopre is renamed to test/qa, the runtests dispatch keys on GROUP == "QA",
and the CI.yml comment is updated. Root package only; lib/* sublibraries are
unaffected.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants