Normalize nopre -> QA (+ split AD/Enzyme)#619
Merged
ChrisRackauckas merged 1 commit intoJun 15, 2026
Conversation
f0de0a5 to
ac77718
Compare
Contributor
Author
|
Branch reset to a clean implementation off the current default branch: removed unrelated changes from the prior revision (no spurious action/codecov version edits), renamed the dep env |
The root nopre group carried only the standard JET static-analysis check, so it is renamed to the canonical QA group at versions ["lts","1"]. The dep env test/nopre is renamed to test/qa, the runtests dispatch keys on GROUP == "QA", and the CI.yml comment is updated. Root package only; lib/* sublibraries are unaffected. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ac77718 to
35143a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fleet-wide nopre/NoPre test-group normalization (policy: standard QA checks live in a canonical
QAgroup on["lts", "1"], ubuntu-only; pre-incompatible functional tests get their own content-named groups).Survey result for this repo: the root
nopregroup was PURE standard QA (JET static analysis only), so it merges into a canonical QA group:test/nopre/→test/qa/(jet_tests.jl→qa.jl, content unchanged).test/runtests.jl: dispatches onGROUP == "QA"(activate_nopre_env→activate_qa_env).test/test_groups.toml:[nopre]→[QA], versions["lts", "1"](unchanged), ubuntu-only. The old comment's rationale for keeping the name lowercase (matching a lowercase CI matrix input) no longer applies — the matrix comes straight from this file..github/workflows/CI.yml: comment updated to name the new group.Notes:
Verification: static only (TOML parse of test_groups.toml + qa/Project.toml;
Meta.parseallof changed .jl files; Runic check clean). Test suites not run locally — CI should confirm the QA group goes green.Ignore until reviewed by @ChrisRackauckas.