Downgrade entity-fishing unreachable errors to warnings#12
Closed
lfoppiano wants to merge 1 commit into
Closed
Conversation
Entity-fishing is an OPTIONAL external service for dataset disambiguation. When it's not configured or unreachable, datastet should continue working without it. Previously, every connection attempt logged ERROR-level messages and stack traces, making it look like a real failure. Changes: - When entityFishingHost is blank, log INFO and skip entirely - When service is unreachable, log single WARN message instead of multiple ERROR stacktraces - runNerd() returns early if server wasn't marked alive at startup - disambiguate() short-circuits if !serverStatus - Replace all e.printStackTrace() with LOGGER.warn() in this class https://claude.ai/code/session_018EBZhK2RtGtsvN4E1rp2tF
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #13 which covers both entity-fishing AND glutton. Please close this one.