Skip to content

Downgrade entity-fishing unreachable errors to warnings #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lfoppiano wants to merge 1 commit into from
Closed

Downgrade entity-fishing unreachable errors to warnings #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions src/main/java/org/grobid/core/engines/DatasetDisambiguator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,19 @@ private DatasetDisambiguator(DatastetConfiguration configuration) {
try {
nerd_host = configuration.getEntityFishingHost();
nerd_port = configuration.getEntityFishingPort();
if (StringUtils.isBlank(nerd_host)) {
LOGGER.info("entity-fishing host not configured, dataset disambiguation will be skipped");
serverStatus = false;
return;
}
serverStatus = checkIfAlive();
if (serverStatus)
if (serverStatus) {
ensureCustomizationReady();
} else {
LOGGER.warn("entity-fishing service is not reachable at " + nerd_host + ":" + nerd_port + ", dataset disambiguation will be skipped");
}
} catch (Exception e) {
LOGGER.error("Cannot read properties for disambiguation service", e);
LOGGER.warn("Cannot initialise disambiguation service, it will be disabled: " + e.getMessage());
}
}

Expand Down Expand Up @@ -111,7 +119,7 @@ public boolean checkIfAlive() {
try (CloseableHttpResponse response = httpClient.execute(get)) {
int code = response.getStatusLine().getStatusCode();
if (code != 200) {
LOGGER.error("Failed isalive service for disambiguation service entity-fishing, HTTP error code : " + code);
LOGGER.warn("entity-fishing isalive returned HTTP " + code + ", disambiguation will be disabled");
return false;
} else {
result = true;
Expand All @@ -120,11 +128,11 @@ public boolean checkIfAlive() {
}

} catch (MalformedURLException e) {
LOGGER.error("Disambiguation service not available: MalformedURLException");
LOGGER.warn("entity-fishing URL is malformed, disambiguation will be disabled");
} catch (HttpHostConnectException e) {
LOGGER.error("Cannot connect to the disambiguation service");
LOGGER.warn("entity-fishing is not reachable, disambiguation will be disabled");
} catch (Exception e) {
LOGGER.error("Disambiguation service not available: generic error", e);
LOGGER.warn("entity-fishing is not available (" + e.getClass().getSimpleName() + "), disambiguation will be disabled");
}

return result;
Expand Down Expand Up @@ -167,11 +175,11 @@ public void ensureCustomizationReady() {
response.close();
}
} catch (MalformedURLException e) {
LOGGER.error("disambiguation service not available: MalformedURLException");
LOGGER.warn("entity-fishing URL is malformed, customization skipped");
} catch (HttpHostConnectException e) {
LOGGER.error("cannot connect to the disambiguation service");
LOGGER.warn("entity-fishing is not reachable, customization skipped");
} catch (Exception e) {
LOGGER.error("disambiguation service not available", e);
LOGGER.warn("entity-fishing customization lookup failed: " + e.getMessage());
}

if (!result && url != null) {
Expand Down Expand Up @@ -239,10 +247,12 @@ public List<Dataset> disambiguate(List<Dataset> entities, List<LayoutToken> toke
if ((entities == null) || (entities.size() == 0))
return entities;
String json = null;
if (!serverStatus)
return entities;
try {
json = runNerd(entities, tokens, "en");
} catch (RuntimeException e) {
LOGGER.error("Call to entity-fishing failed.", e);
LOGGER.warn("Call to entity-fishing failed: " + e.getMessage());
}
if (json == null)
return entities;
Expand Down Expand Up @@ -448,8 +458,7 @@ public List<Dataset> disambiguate(List<Dataset> entities, List<LayoutToken> toke
// e.g. [{"weight" : 0.16666666666666666, "source" : "wikipedia-en", "category" : "Bioinformatics", "page_id" : 726312}, ...

} catch (Exception e) {
LOGGER.error("Invalid JSON answer from the NERD", e);
e.printStackTrace();
LOGGER.warn("Invalid JSON answer from entity-fishing, skipping disambiguation: " + e.getMessage());
}

return entities;
Expand Down Expand Up @@ -566,7 +575,7 @@ public String runNerd(List<Dataset> entities, List<LayoutToken> subtokens, Strin

int code = response.getStatusLine().getStatusCode();
if (code != 200) {
LOGGER.error("Failed annotating text segment: HTTP error code : " + code);
LOGGER.warn("entity-fishing annotation returned HTTP " + code + ", skipping disambiguation");
return null;
}

Expand All @@ -584,9 +593,9 @@ public String runNerd(List<Dataset> entities, List<LayoutToken> subtokens, Strin
response.close();
}
} catch (MalformedURLException e) {
e.printStackTrace();
LOGGER.warn("entity-fishing URL is malformed, skipping disambiguation");
} catch (IOException e) {
e.printStackTrace();
LOGGER.warn("entity-fishing request failed: " + e.getMessage());
}
return output.toString().trim();
}
Expand Down
Loading