Skip to content

docs(agents): make the pull-request review rule neutral about who reviews - #453

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
docs/neutral-review-process
Sep 3, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
docs/neutral-review-process

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

AGENTS.md › Pull requests: remove the "Never solicit external reviews: no @codex review comments, no waiting for the connector, no unreviewed-SHA bookkeeping" bullet (landed via #449, which itself replaced the #433 @codex review / reviewer-quota-fallback rules). The repository guidance now carries no instruction about soliciting Codex reviews in either direction.

What stays: CI green first; address every review thread, whoever opened it, and re-check after each push until none remain; squash-merge; threads left on a merged PR are answered in a follow-up PR. The local self-review bullet is untouched.

Checked for the same review-process text and found none elsewhere: .cursor/rules/** (absent), .changeset/README.md, hand-written docs/**, website/docs/{en,zh}/** (excluding generated api/**). packages/agent-bundle/src/adapters/capabilities/codex-*.json describes Codex as a host target and is out of scope.

Docs-only, root file; no publishable package changes, so the Changeset present check does not require a changeset.

…iews

Drop the "never solicit external reviews" bullet. The section now says only
what the merge gate is: CI green, every review thread answered whoever
opened it, squash-merge, follow-up PR for threads on merged PRs.
@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9528bf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@453
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@453
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@453

commit: 9528bf2

@ScriptedAlchemy
ScriptedAlchemy merged commit 22b354f into main Sep 3, 2026
13 of 14 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the docs/neutral-review-process branch September 3, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant