docs(agents): make the pull-request review rule neutral about who reviews - #453
Merged
Merged
Conversation
…iews Drop the "never solicit external reviews" bullet. The section now says only what the merge gate is: CI green, every review thread answered whoever opened it, squash-merge, follow-up PR for threads on merged PRs.
|
To use Codex here, create an environment for this repo. |
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md› Pull requests: remove the "Never solicit external reviews: no@codex reviewcomments, no waiting for the connector, no unreviewed-SHA bookkeeping" bullet (landed via #449, which itself replaced the #433@codex review/ reviewer-quota-fallback rules). The repository guidance now carries no instruction about soliciting Codex reviews in either direction.What stays: CI green first; address every review thread, whoever opened it, and re-check after each push until none remain; squash-merge; threads left on a merged PR are answered in a follow-up PR. The local self-review bullet is untouched.
Checked for the same review-process text and found none elsewhere:
.cursor/rules/**(absent),.changeset/README.md, hand-writtendocs/**,website/docs/{en,zh}/**(excluding generatedapi/**).packages/agent-bundle/src/adapters/capabilities/codex-*.jsondescribes Codex as a host target and is out of scope.Docs-only, root file; no publishable package changes, so the
Changeset presentcheck does not require a changeset.