Skip to content

[Tests] Remove filesystem mocks in request.test.ts - #7620

Merged
gonzaloriestra merged 1 commit into
mainfrom
tests-remove-fs-mocks-request-15124592611028508660
Jun 4, 2026
Merged

[Tests] Remove filesystem mocks in request.test.ts#7620
gonzaloriestra merged 1 commit into
mainfrom
tests-remove-fs-mocks-request-15124592611028508660

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 24, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

This pull request addresses the testing anti-pattern of mocking the filesystem in packages/store/src/cli/services/store/execute/request.test.ts. Mocking the filesystem can lead to brittle tests that don't accurately reflect real-world behavior.

WHAT is this pull request doing?

  • Removed global vi.mock('@shopify/cli-kit/node/fs') from packages/store/src/cli/services/store/execute/request.test.ts.
  • Updated test cases to use real filesystem operations within temporary directories using inTemporaryDirectory and writeFile.
  • Updated imports to include inTemporaryDirectory and joinPath.

How to test your changes?

CI

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 15124592611028508660 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 24, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 25, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review May 25, 2026 08:40
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner May 25, 2026 08:40
@amcaplan

amcaplan commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@jules fix the merge conflicts

@gonzaloriestra
gonzaloriestra force-pushed the tests-remove-fs-mocks-request-15124592611028508660 branch from a7c9f3f to ae61ec4 Compare June 4, 2026 06:49
@gonzaloriestra

Copy link
Copy Markdown
Contributor Author

@amcaplan @jules is a random guy 😅

It's @google-labs-jules

@gonzaloriestra
gonzaloriestra enabled auto-merge June 4, 2026 06:51
@google-labs-jules

Copy link
Copy Markdown

@amcaplan @jules is a random guy 😅

It's @google-labs-jules

Acknowledged. Thank you for the correction regarding my handle!

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Jun 4, 2026
@google-labs-jules

Copy link
Copy Markdown

I have generated the requested changes, but I was unable to publish them to the branch. You can publish the changes manually from the Jules UI.

Merged via the queue into main with commit 6ea2183 Jun 4, 2026
28 of 29 checks passed
@gonzaloriestra
gonzaloriestra deleted the tests-remove-fs-mocks-request-15124592611028508660 branch June 4, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants