Skip to content

[Tests] Remove filesystem mocks in request.test.ts #7620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Jun 4, 2026
Merged

[Tests] Remove filesystem mocks in request.test.ts #7620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions packages/store/src/cli/services/store/execute/request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,28 +22,29 @@ describe('prepareStoreExecuteRequest', () => {
test('reads the query from a file', async () => {
await inTemporaryDirectory(async (tmpDir) => {
// Given
const queryPath = joinPath(tmpDir, 'operation.graphql')
await writeFile(queryPath, 'query { shop { name } }')
const queryFile = joinPath(tmpDir, 'operation.graphql')
const queryContent = 'query { shop { name } }'
await writeFile(queryFile, queryContent)

// When
const request = await prepareStoreExecuteRequest({
queryFile: queryPath,
queryFile,
})

// Then
expect(request.query).toBe('query { shop { name } }')
expect(request.query).toBe(queryContent)
})
})

test('throws when the query file does not exist', async () => {
await inTemporaryDirectory(async (tmpDir) => {
// Given
const queryPath = joinPath(tmpDir, 'missing.graphql')
const missingFile = joinPath(tmpDir, 'missing.graphql')

// When/Then
await expect(
prepareStoreExecuteRequest({
queryFile: queryPath,
queryFile: missingFile,
}),
).rejects.toThrow('Query file not found')
})
Expand All @@ -60,13 +61,13 @@ describe('prepareStoreExecuteRequest', () => {
test('throws when the query file is empty', async () => {
await inTemporaryDirectory(async (tmpDir) => {
// Given
const queryPath = joinPath(tmpDir, 'operation.graphql')
await writeFile(queryPath, ' ')
const queryFile = joinPath(tmpDir, 'operation.graphql')
await writeFile(queryFile, ' ')

// When/Then
await expect(
prepareStoreExecuteRequest({
queryFile: queryPath,
queryFile,
}),
).rejects.toThrow('is empty')
})
Expand Down Expand Up @@ -121,15 +122,18 @@ describe('prepareStoreExecuteRequest', () => {
test('reads variables from a file', async () => {
await inTemporaryDirectory(async (tmpDir) => {
// Given
const queryPath = joinPath(tmpDir, 'operation.graphql')
const variablesPath = joinPath(tmpDir, 'variables.json')
await writeFile(queryPath, 'query { shop { id } }')
await writeFile(variablesPath, '{"id":"gid://shopify/Shop/1"}')
const queryFile = joinPath(tmpDir, 'operation.graphql')
const variablesFile = joinPath(tmpDir, 'variables.json')
const queryContent = 'query { shop { id } }'
const variablesContent = '{"id":"gid://shopify/Shop/1"}'

await writeFile(queryFile, queryContent)
await writeFile(variablesFile, variablesContent)

// When
const request = await prepareStoreExecuteRequest({
queryFile: queryPath,
variableFile: variablesPath,
queryFile,
variableFile: variablesFile,
})

// Then
Expand Down
Loading