Explain the empty-organization store creation prompts in app dev - #8460
Merged
Conversation
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 18:31
98be77e to
2f7a590
Compare
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 18:33
2f7a590 to
08d8eef
Compare
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 18:49
08d8eef to
7c6ac7f
Compare
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 18:52
7c6ac7f to
c59cc36
Compare
dmerand
approved these changes
Sep 2, 2026
dmerand
left a comment
Contributor
There was a problem hiding this comment.
I could have sworn the original implementation had this... I definitely thought I'd done it but maybe it didn't make its way into the final PR. Thanks for updating!
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 20:28
c59cc36 to
906dec5
Compare
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 20:29
906dec5 to
d9ed385
Compare
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 21:17
d9ed385 to
dbe00fd
Compare
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 21:20
dbe00fd to
853fcb1
Compare
amcaplan
approved these changes
Sep 2, 2026
amcaplan
left a comment
Contributor
There was a problem hiding this comment.
The change makes sense. Great catch!
An organization with no dev stores drops straight into "Name for the new development store", which arrives without context: the developer asked to run `app dev`, not to create a store. Render a short notice first. The store picker's "Create a new dev store" choice stays quiet, because there the developer already expressed the intent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/a27b4557-3ac8-448a-8860-7a5ed6b20687
nickwesselman
force-pushed
the
nick/dev-store-empty-org-notice
branch
from
September 2, 2026 21:43
853fcb1 to
d36cd04
Compare
Contributor
Author
|
/snapit |
1 similar comment
Contributor
Author
|
/snapit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked PR. Base is
nick/dev-store-demo-data-prompt(#8459), notmain. Do notmerge before #8459.
WHY are these changes introduced?
Since #8323, an App Management organization with no dev stores drops straight into
"Name for the new development store" when you run
app dev. The prompt arrives withoutcontext: the developer asked to start a dev session, not to create a store, and the old
flow that explained the situation ("Looks like you don't have any dev stores associated
with …") was replaced by inline creation.
WHAT is this pull request doing?
Renders a short notice before the creation prompts on the zero-store path:
Scoped deliberately to the zero-store path. When a developer picks "Create a new dev
store" from the store picker, they have already expressed the intent, so a notice
explaining why they are being asked would be noise. That is why the message lives in the
onCreateStoreWhenEmptywrapper rather than insidecreateStoreInline, which both pathsshare. Wrapping the callback rather than placing
renderInfobeside the cap and TTYguards also means the notice cannot print if the prompts never run. Tests assert it both
ways — present on the zero-store path,
expect(renderInfo).not.toHaveBeenCalled()on thepicker path.
One naming note for reviewers: the message hardcodes "Dev Dashboard", matching the
adjacent copy in
AppManagementClient.getCreateDevStoreLink. The client also carries awebUiNameproperty whose value is'Developer Dashboard', so the codebase alreadydisagrees with itself about the product name. Using
webUiNamehere would render"Developer Dashboard" instead. Reconciling the two feels like its own cleanup rather than
part of this change, but say the word if you would rather this PR use
webUiName.How to test your changes?
shopify app dev --reset. The notice appears, naming the organization, before thestore name prompt.
shopify app dev --resetin an organization that does have dev stores and pick"Create a new dev store" from the picker. No notice — straight to the name prompt.
Changelog
No changeset. This builds on the inline dev store creation from #8323 and #8397, which is
not released yet, so the whole flow will be covered by a single changelog entry rather than
one per PR in this stack.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add— intentionally omitted, see Changelog above