Skip to content

Explain the empty-organization store creation prompts in app dev #8460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickwesselman merged 1 commit into from
Sep 2, 2026
Merged

Explain the empty-organization store creation prompts in app dev #8460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/app/src/cli/services/dev/select-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
import {testDeveloperPlatformClient} from '../../models/app/app.test-data.js'
import {ClientName} from '../../utilities/developer-platform-client.js'
import {sleep} from '@shopify/cli-kit/node/system'
import {isTTY, renderSuccess, renderTasks, Task} from '@shopify/cli-kit/node/ui'
import {isTTY, renderInfo, renderSuccess, renderTasks, Task} from '@shopify/cli-kit/node/ui'
import {AbortError, CancelExecution} from '@shopify/cli-kit/node/error'
import {createDevStore} from '@shopify/organizations'
import {beforeEach, describe, expect, vi, test} from 'vitest'
Expand Down Expand Up @@ -404,6 +404,8 @@ describe('selectStore', async () => {
json: false,
summary: false,
})
// The developer picked the create choice, so no explanatory notice is needed.
expect(renderInfo).not.toHaveBeenCalled()
expect(renderSuccess).toHaveBeenCalledWith({headline: 'Development store "store1" created successfully.'})
})

Expand Down Expand Up @@ -477,6 +479,9 @@ describe('selectStore', async () => {
})
expect(fetchStore).toHaveBeenCalledTimes(2)
expect(sleep).toHaveBeenCalledWith(3)
expect(renderInfo).toHaveBeenCalledWith({
body: "You don't have any dev stores associated with org1's Dev Dashboard. Let's create one.",
})
expect(renderSuccess).toHaveBeenCalledWith({headline: 'Development store "store1" created successfully.'})
})

Expand Down
11 changes: 10 additions & 1 deletion packages/app/src/cli/services/dev/select-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,12 @@ export async function selectStore(
if (isTTY() === false) {
throw new AbortError('No development store was specified.', createDevStoreTryMessage(org.id))
}
onCreateStoreWhenEmpty = createStoreInline
// The developer never asked to create a store here, so explain why they are being
// prompted. The picker's create choice is self-explanatory and stays quiet.
onCreateStoreWhenEmpty = async () => {
renderInfo({body: emptyOrgNoticeBody(org)})
return createStoreInline()
}
} else if (storeCreationEnabled && storeCreationMode === 'selection-option') {
if (isTTY() === false && (storesSearch.stores.length > 1 || storesSearch.hasMorePages)) {
throw new AbortError(
Expand Down Expand Up @@ -175,6 +180,10 @@ async function waitForCreatedStore(

const devStoreCapReachedMessage = 'Your organization has reached its development store limit.'

function emptyOrgNoticeBody(org: Organization): string {
return `You don't have any dev stores associated with ${org.businessName}'s Dev Dashboard. Let's create one.`
}

function devStoreCreationCommand(orgId: string): string {
return `shopify store create dev --organization-id ${orgId} --name <store-name> --plan <plan>`
}
Expand Down
Loading