add edit tool formatters#1018
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
This was referenced Jul 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 2, 2026
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
from
852ae68 to
f2399f0
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
from
2d3ce63 to
7730ee2
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
from
f2399f0 to
4166e5d
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
from
7730ee2 to
676a57b
Compare
LasmarKhalifa
requested review from
dersam,
juniper-shopify,
mathiusj and
nfgrep
as code owners
mathiusj
reviewed
Jul 3, 2026
mathiusj
left a comment
mathiusj
left a comment
Contributor
There was a problem hiding this comment.
edit formatters look good. Two small things.
mathiusj
approved these changes
Jul 3, 2026
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
from
676a57b to
6401f99
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
2 times, most recently
from
1d5f2cb to
58bc7d6
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
2 times, most recently
from
27d834e to
9f3ab5a
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
from
58bc7d6 to
0c38e90
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
from
9f3ab5a to
a161e59
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
from
0c38e90 to
5e31fef
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
from
a161e59 to
a785239
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
from
5e31fef to
32856c2
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-write
branch
from
32856c2 to
80dee98
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-edit
branch
from
a785239 to
d3310c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1026