add find tool formatters#1020
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
This was referenced Jul 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
2eeb38f to
eba0fd6
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
86c73f5 to
3b64e5c
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
eba0fd6 to
96d8a9b
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
3b64e5c to
10a0676
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
96d8a9b to
554abfb
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
2 times, most recently
from
3799ee2 to
919a175
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
2 times, most recently
from
8a4b6f3 to
621fd97
Compare
LasmarKhalifa
requested review from
dersam,
juniper-shopify,
mathiusj and
nfgrep
as code owners
mathiusj
reviewed
Jul 3, 2026
mathiusj
left a comment
mathiusj
left a comment
Contributor
There was a problem hiding this comment.
find formatter looks good.
mathiusj
approved these changes
Jul 3, 2026
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
621fd97 to
dd0821d
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
2 times, most recently
from
2ad8c53 to
74166f6
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
dd0821d to
1d2092c
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
74166f6 to
f877583
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
1d2092c to
eef857c
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
f877583 to
f55f3f1
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
eef857c to
b9177ad
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
f55f3f1 to
d0bc73d
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
2 times, most recently
from
9857673 to
5cbb42c
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
d0bc73d to
5beb941
Compare
dersam
reviewed
Jul 14, 2026
| # | ||
| #: () -> String | ||
| def format_find | ||
| count = content.to_s.lines.map(&:strip).reject(&:empty?).length |
Contributor
There was a problem hiding this comment.
Missing NOTE handling for status/truncation messages. format_find counts all non-blank lines as paths with no partition into results vs. notes. The sibling format_grep (PR #1019) and Claude's format_glob both partition output and append a truncated NOTE <message> when status lines accompany results. A truncation notice like "Results truncated" would inflate the path count and silently drop the diagnostic — e.g. lib/a.rb\nlib/b.rb\nResults truncated renders FIND OK 3 paths instead of FIND OK 2 paths · NOTE Results truncated.
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
5cbb42c to
5f80803
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
5beb941 to
c15e82c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1028