Fix 1 stale doc comment(s) across 1 file(s)#1034
Conversation
| end | ||
|
|
||
| # Normalize a number string by removing separators and currency codes and validating format | ||
| # Normalize a number string by removing separators and currency symbols and validating format |
There was a problem hiding this comment.
Inline comment on line 256 has the same stale phrase. The PR correctly fixes the method-level doc comment ("currency codes" → "currency symbols"), but the inline comment inside the method body (# Remove common digit separators and currency codes) has the exact same inaccuracy. Both should be updated together.
There was a problem hiding this comment.
I agree. I had originally scoped this to just doc comments, but looking back it makes sense to include inline comments too. I made a few changes to the workflow itself to allow inline comments to be reviewed. I ran the same file on it again and got this PR which now fully fixes the comments! Noramlly, it would have updated the same PR instead of creating a new one, but I changed the branch naming convention since we support inline comments too, which made the new PR appear to be a new branch.
Thanks for flagging this, I think it's the right call to have inline comments being processed in the same workflow!
a5f0059 to
2c10411
Compare
b551f4d to
ed8b741
Compare
2c10411 to
af3881b
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 participants
Automated doc-comment audit on top of
07-10/doc-comment-audit-workflow(basea5f0059424).lib/roast/cog/output.rb[\s$¢£€¥,_]only strips whitespace, the currency symbols $¢£€¥, commas, and underscores — no letters are stripped, so alphabetic currency codes like 'USD' or 'EUR' are not removed.