Skip to content

Fix 2 stale comment(s) across 1 file(s)#1037

Draft
LasmarKhalifa wants to merge 1 commit into
07-10/doc-comment-audit-workflowfrom
comment-audit/07-10-doc-comment-audit-workflow
Draft

Fix 2 stale comment(s) across 1 file(s)#1037
LasmarKhalifa wants to merge 1 commit into
07-10/doc-comment-audit-workflowfrom
comment-audit/07-10-doc-comment-audit-workflow

Conversation

@LasmarKhalifa

Copy link
Copy Markdown
Contributor

Automated comment audit on top of 07-10/doc-comment-audit-workflow (base 2c10411077).

lib/roast/cog/output.rb

  • Roast::Cog::Output::WithNumber#normalize_number_string (confidence 0.9)
    • "currency codes" is wrong terminology: the method's gsub(/[\s$¢£€¥,_]/, "") strips currency symbols ($, ¢, £, €, ¥) and separator characters (whitespace, comma, underscore), not alphabetic currency codes like USD or EUR. The neighboring comment at output.rb:242 correctly calls these "currency symbols".
    • evidence: lib/roast/cog/output.rb:252 (comment), lib/roast/cog/output.rb:255-261 (implementation), lib/roast/cog/output.rb:242 (sibling comment using correct term "currency symbols")
  • inline @ L256 (confidence 0.9)
    • The comment says the code removes 'currency codes', but the regex /[\s$¢£€¥,_]/ (line 257) only matches whitespace, digit separators (comma, underscore), and currency symbols ($¢£€¥). It contains no letters, so it never strips alphabetic currency codes like USD or EUR.
    • evidence: lib/roast/cog/output.rb:256-257

@LasmarKhalifa LasmarKhalifa force-pushed the 07-10/doc-comment-audit-workflow branch from 2c10411 to af3881b Compare July 14, 2026 22:48
@LasmarKhalifa LasmarKhalifa force-pushed the comment-audit/07-10-doc-comment-audit-workflow branch from 1f2aa9e to b667905 Compare July 14, 2026 22:50

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant